Skip to content

Commit

Permalink
Merge pull request #93 from dorssel/strongname
Browse files Browse the repository at this point in the history
Revert remove strong name
  • Loading branch information
dorssel authored Jan 16, 2025
2 parents 54e5e75 + 5a285b8 commit 3fac405
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 3 deletions.
3 changes: 1 addition & 2 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ SPDX-License-Identifier: MIT
<IsPackable>false</IsPackable>
<IsPublishable>false</IsPublishable>
<IsTrimmable>true</IsTrimmable>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)\strongname.snk</AssemblyOriginatorKeyFile>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<!-- See: https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming#create-strong-named-net-libraries -->
<SignAssembly>false</SignAssembly>

<!-- Assembly metadata -->
<Product>dotnet-ef-sqlite-timestamp</Product>
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ See the Example project for a demonstration using .NET 9 & EF Core 9.
The released [NuGet package](https://www.nuget.org/packages/Dorssel.EntityFrameworkCore.Sqlite.Timestamp)
and the .NET assemblies contained therein have the following properties:

- [Strong Naming](https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming)
- [SourceLink](https://learn.microsoft.com/en-us/dotnet/standard/library-guidance/sourcelink)
- [IntelliSense](https://learn.microsoft.com/en-us/visualstudio/ide/using-intellisense)
- [Authenticode](https://learn.microsoft.com/en-us/windows/win32/seccrypto/time-stamping-authenticode-signatures#a-brief-introduction-to-authenticode)
3 changes: 2 additions & 1 deletion SqliteTimestamp/SqliteTimestamp.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ SPDX-License-Identifier: MIT
<TargetFramework>net8.0</TargetFramework>
<RootNamespace>Dorssel.EntityFrameworkCore</RootNamespace>
<AssemblyName>Dorssel.EntityFrameworkCore.Sqlite.Timestamp</AssemblyName>
<SignAssembly>true</SignAssembly>

<IsPackable>true</IsPackable>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
Expand All @@ -22,7 +23,7 @@ SPDX-License-Identifier: MIT
</ItemGroup>

<ItemGroup>
<!-- Override to support EF 8 consumers of our package. -->
<!-- Override to also support EF Core 8 consumers of our package. -->
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" VersionOverride="8.0.12" />
</ItemGroup>

Expand Down
17 changes: 17 additions & 0 deletions UnitTests/AssemblyTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// SPDX-FileCopyrightText: 2025 Frans van Dorsselaer
//
// SPDX-License-Identifier: MIT

namespace UnitTests;

[TestClass]
sealed class AssemblyTests
{
[TestMethod]
public void StrongName()
{
var publicKeyToken = typeof(SqliteTimestampDbContextOptionsBuilderExtensions).Assembly.GetName().GetPublicKeyToken();
Assert.IsNotNull(publicKeyToken);
Assert.IsTrue(publicKeyToken.Length > 0);
}
}
Binary file added strongname.snk
Binary file not shown.
3 changes: 3 additions & 0 deletions strongname.snk.license
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
SPDX-FileCopyrightText: 2024 Frans van Dorsselaer

SPDX-License-Identifier: MIT

0 comments on commit 3fac405

Please sign in to comment.