This repository was archived by the owner on Jul 10, 2024. It is now read-only.
Final updates for 2.1 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates, Fixes for 2.1
jongalloway
reviewed
Jun 22, 2018
| @@ -1,5 +1,12 @@ | |||
| # ASP.NET Core - App Building Workshop | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
Badge points to https://msft-shayne.visualstudio.com - should this be the permanent location?
There was a problem hiding this comment.
Probably not. If we can get a .NET Foundation instance we can move the VSTS Build system there as well as the AppService Instances and ACR etc.
There was a problem hiding this comment.
Okay, cool. Not a reason to block here, I'm merge and we can add another issue to track.
jongalloway
reviewed
Jun 22, 2018
| @@ -1,6 +1,10 @@ | |||
| version: '3.4' | |||
| version: '3.3' | |||
There was a problem hiding this comment.
Is there a reason to go from 3.4 to 3.3 here?
There was a problem hiding this comment.
VSTS Build Agent does not support 3.4 yet. No major difference.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All builds pass for 2.1:
Manual Build of ASP.NET Workshop-ASP.NET Core-CI (ASP.NET Workshop)
Ran for 5.6 minutes (Hosted VS2017), completed at Wed 06/06/2018 03:08 AM
0 error(s), 0 warning(s)