Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor SignalR UE pass #21620

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Blazor SignalR UE pass #21620

merged 2 commits into from
Mar 4, 2021

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Feb 24, 2021

Addresses #19286

Internal Review Topic

The primary review request is to confirm that the sections and content for each of the WASM and Server pivots are correct. However, I did touch-up quite a bit here ... probably best to run an 👁️ over everything.

@guardrex guardrex marked this pull request as ready for review February 25, 2021 10:18
@guardrex guardrex closed this Mar 4, 2021
@guardrex guardrex reopened this Mar 4, 2021
@guardrex guardrex requested a review from BrennanConroy March 4, 2021 10:25
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm starting to like these pivots 😄

@@ -322,43 +346,6 @@ window.addEventListener('pagehide', () => {
});
```

<!-- HOLD for reactivation at 5x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to this?

Copy link
Collaborator Author

@guardrex guardrex Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it into a TXT file on my desktop. Safia and I will re-activate it somewhere for 6.0. I thought originally that it would be like a 5.1 thing, but that's not going to be a thing. It's a 6.0 scenario ...

dotnet/aspnetcore#25705

@guardrex guardrex merged commit 70dca5d into master Mar 4, 2021
@guardrex guardrex deleted the guardrex/blazor-signalr branch March 4, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants