Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIMD disable guidance 8.0 #30924

Merged
merged 8 commits into from
Nov 3, 2023
Merged

Update SIMD disable guidance 8.0 #30924

merged 8 commits into from
Nov 3, 2023

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Nov 3, 2023

Fixes #30923


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/tooling.md Tooling for ASP.NET Core Blazor

@guardrex guardrex requested a review from maraf November 3, 2023 13:00
@guardrex guardrex self-assigned this Nov 3, 2023
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@maraf
Copy link
Member

maraf commented Nov 3, 2023

One nit, unrelated. Can we change the URL for wasm features documentation? Instead of directly pointing to .md file on github, use aka link https://aka.ms/dotnet-wasm-features#simd---single-instruction-multiple-data

@guardrex
Copy link
Collaborator Author

guardrex commented Nov 3, 2023

There are two links here, and I may have updated the wrong one.

UPDATE: Ok, that should do it. 👇

@guardrex
Copy link
Collaborator Author

guardrex commented Nov 3, 2023

Sorry about that, @maraf ... I just walked in the door after being OOF for a couple of hours, so my head wasn't in the game here. It should be in good shape now.

@maraf
Copy link
Member

maraf commented Nov 3, 2023

No worries. It's awesome now, thank you!

@guardrex guardrex enabled auto-merge (squash) November 3, 2023 16:13
@guardrex guardrex merged commit c8e3dc9 into main Nov 3, 2023
@guardrex guardrex deleted the guardrex-patch-3 branch November 3, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[blazor] SIMD can be disabled
2 participants