Merge: Generalize pool and move to shared #1199
Merged
+24
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRahnama
reviewed
Aug 4, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Pool.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Pool.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Pool.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
added
the
Code Health 💊
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
cheenamalhotra
approved these changes
Sep 22, 2021
johnnypham
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a threadsafe object pool in the netcore that is used for keeping SNIPackets. This PR generalizes that pool so it can be used for any class type because I want to use it for SqlEnvChange. Once this is merged I'll be able to port the netcore SqlEnvChange implementation with recycling and renting to netfx and then pool the env change objects to eliminate a per use allocation.