Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup | DbConnectionInternal #2934

Merged
merged 8 commits into from
Nov 1, 2024

Conversation

benrr101
Copy link
Contributor

Description: This is the second half of #2910 that applies cleanup to DbConnectionInternal. The PR is meant to be highly granular with each commit being individually reviewable. Ideally, I'd recommend going through the PR commit-by-commit and review each cleanup change.

Testing: Test cases are still passing, so I suspect this is a safe change.

@cheenamalhotra
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 80.79470% with 29 lines in your changes missing coverage. Please review.

Project coverage is 72.24%. Comparing base (39c4604) to head (e92fbf9).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...icrosoft/Data/ProviderBase/DbConnectionInternal.cs 81.08% 28 Missing ⚠️
...icrosoft/Data/SqlClient/SqlDelegatedTransaction.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
+ Coverage   71.92%   72.24%   +0.32%     
==========================================
  Files         294      291       -3     
  Lines       60342    59766     -576     
==========================================
- Hits        43398    43178     -220     
+ Misses      16944    16588     -356     
Flag Coverage Δ
addons 92.90% <ø> (ø)
netcore 75.82% <79.72%> (-0.02%) ⬇️
netfx 70.61% <80.82%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101 benrr101 merged commit fd77d53 into dotnet:main Nov 1, 2024
124 checks passed
@benrr101 benrr101 deleted the cleanup/dbconnectioninternal branch November 1, 2024 17:19
@mdaigle mdaigle added the ➕ Code Health Issues/PRs that are targeted to source code quality improvements. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants