-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge | Move ReliabilitySection / BestEffortCleanup to framework specific files #2984
Merge | Move ReliabilitySection / BestEffortCleanup to framework specific files #2984
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
==========================================
+ Coverage 72.64% 72.67% +0.02%
==========================================
Files 285 286 +1
Lines 59160 59160
==========================================
+ Hits 42979 42995 +16
+ Misses 16181 16165 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c634c01
to
ac8aa33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this makes sense and is probably a good idea. Still not a huge fan of the conditional attribute, but since it's already there, I won't raise a fuss :)
@MichelZ if you can resolve the conflict, I can get this merged 🚢 |
@benrr101 Done! Thx |
I don't think we want to wrap those in #IF NETFRAMEWORK / NETCORE conditional compiles, it makes sense to have them in their own files, so I've moved them out of the "future-common-project" file(s)
Part of #2953