Correct GetParseSynonyms' failing debug assertion #3088
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3088 +/- ##
==========================================
- Coverage 72.74% 72.73% -0.01%
==========================================
Files 283 283
Lines 58968 58968
==========================================
- Hits 42894 42891 -3
- Misses 16074 16077 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -132,7 +132,7 @@ private enum Keywords | |||
| private bool _transparentNetworkIPResolution = DbConnectionStringDefaults.TransparentNetworkIPResolution; | |||
| private string _networkLibrary = DbConnectionStringDefaults.NetworkLibrary; | |||
| #else | |||
| internal const int DeprecatedKeywordsCount = 5; | |||
There was a problem hiding this comment.
Can we get rid of this counter?
There was a problem hiding this comment.
I don't think so. It's used to mark keywords which are supported in .NET Framework but not in .NET Core. These are Connection Reset and Network Library. Connection Reset should be a fairly easy keyword to merge, but Network Library needs a little more thought - what connection method should we use if the Network Library keyword requests named pipes, but the Server keyword requests TCP?
There was a problem hiding this comment.
" if the Network Library keyword requests named pipes, but the Server keyword requests TCP"
Invalid connection string?
There was a problem hiding this comment.
Not needed, because the connection would fail itself.
Deprecation wise, network library is replaced with 'tcp/np:' in DataSource property, so we need not worry about handling it.
|
Replacing this proposal with #3098 |
Fixes #3016