[5.2] Port PR 2896 (Allow errors with negative numbers to be considered transient) #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmedynski
approved these changes
Jan 8, 2025
mdaigle
approved these changes
Jan 8, 2025
cheenamalhotra
approved these changes
Jan 8, 2025
|
/azp run |
cheenamalhotra
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@edwardneal I must've been out of my mind yesterday b/c I thought I responded to this, but I guess I did not. Same thing applies to this PR as did to the other one we did recently. So I am taking this PR into dotnet repo and re-submitting it, so we can get all the CI to work. Sorry this is so confusing (or maybe I'm just projecting). I (we) definitely appreciate you help in getting some of these little things off the heap of projects we need to do. Closing in favor of #3185 |
|
Thanks @benrr101, I was expecting the same thing for this PR so there's no confusion. It'll be good to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #2896.
Fixes #2890 in v5.2.x.
If possible, could this be rolled into the same 5.2 release as #3076 please?