Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Sync ref project references with runtime projects #3153

Conversation

edwardneal
Copy link
Contributor

Ports #2878 and #3124.
Fixes #2541. Fixes #2082.

@benrr101 benrr101 requested a review from a team February 19, 2025 18:56
@benrr101
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I don't want to see the ref projects ever again, so anything that touches them is probably fine 😅

@mdaigle mdaigle added this to the 5.1.7 milestone Feb 19, 2025
@benrr101
Copy link
Contributor

@edwardneal sorry for the annoyances on this stuff... the secrets things has been a real pain for everyone and I also think our branching strategy contributes to the pain. We were discussing this PR at triage today and came up with two options:

  • Backport the secrets change that David made into all the current support branches, then get this one merged
  • Remake the PR under dotnet repo, and get it merged.

Since we don't intend to backport many changes to these branches, we're going to take the second option. Hopefully that's not a huge issue - I'll make sure you still get the credit for the commits!

@edwardneal
Copy link
Contributor Author

That sounds good to me, thanks @benrr101!

@benrr101
Copy link
Contributor

Closing in favor of #3180 to pick up full CI run

@benrr101 benrr101 closed this Feb 25, 2025
@edwardneal edwardneal deleted the port/5.1/sync-ref-project-dependencies branch February 28, 2025 06:34
@cheenamalhotra cheenamalhotra removed this from the 5.1.7 milestone Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants