Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating NuGet package dependencies #8124

Merged
merged 4 commits into from
Mar 18, 2025
Merged

Conversation

joperezr
Copy link
Member

Description

Updating NuGet Package Dependencies.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

@Copilot Copilot bot review requested due to automatic review settings March 17, 2025 20:44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 17, 2025
@joperezr
Copy link
Member Author

cc: @eerhardt @ailtonguitar @sebastienros seems like the failures on MongoDB.Driver are legit issues when bumping to MongoDB.Driver version 3.2.1.

@eerhardt
Copy link
Member

cc: @eerhardt @ailtonguitar @sebastienros seems like the failures on MongoDB.Driver are legit issues when bumping to MongoDB.Driver version 3.2.1.

The problem was a change in the MongoDB TestContainer - testcontainers/testcontainers-dotnet#1369. We were assuming we could append the database name on to the connection string directly. I pushed a fix to use UriBuilder to set the database name.

@joperezr joperezr enabled auto-merge (squash) March 18, 2025 17:06
<PackageVersion Include="Microsoft.DotNet.Build.Tasks.Workloads" Version="8.0.0-beta.23564.4" />
<PackageVersion Include="Microsoft.Signed.Wix" Version="$(MicrosoftSignedWixVersion)" />
<PackageVersion Include="Microsoft.DotNet.Build.Tasks.Installers" Version="8.0.0-beta.23564.4" />
<PackageVersion Include="Microsoft.DotNet.GenAPI.Task" Version="9.0.103-servicing.25065.25" />
<PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.25072.1" />
<!-- unit test dependencies -->
<PackageVersion Include="bUnit" Version="1.33.3" />
<PackageVersion Include="JsonSchema.Net" Version="7.3.1" />
<PackageVersion Include="bUnit" Version="1.36.0" /> <!-- Can't update passed to 1.37.x versions as those lift up LTS versions when targeting net8 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the only one this lifts up is System.Text.Json, right? That should be OK for our tests, I would think. It is just the Dashboard Components Tests.

cc @JamesNK @adamint

@joperezr joperezr merged commit 624e7a4 into dotnet:main Mar 18, 2025
164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants