Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the VB Language spec #2681

Merged
merged 2 commits into from
Jul 22, 2017
Merged

Publish the VB Language spec #2681

merged 2 commits into from
Jul 22, 2017

Conversation

BillWagner
Copy link
Member

Fixes #1562

This publishes the markdown source from the vblang repository on docs.

The content is from the dependent repo, so reviews will need to happen on the review site.

/cc @AnthonyDGreen

This publishes the markdown source from the vblang repository on docs.
@rpetrusha
Copy link
Contributor

Closing and reopening to trigger new build.

@BillWagner
Copy link
Member Author

I looked at the generated markdown this morning, and it looks good on the review site.

Comments on the metadata or other sections?

@AnthonyDGreen
Copy link
Contributor

How do I view this as externals would see it rendered?

@BillWagner
Copy link
Member Author

@AnthonyDGreen The build from this PR is on the review site. That's currently internal only. I sent you the link in email this morning.

@rpetrusha
Copy link
Contributor

@AnthonyDGreen, the "All checks..." section below includes an "OpenPublishing.Build" validation stage. Its Details link opens a page that has a list of URLs of the pages built as a result of the PR. They're preview rather than production pages, but they are identical to the production pages that will be built if the PR in its current state is merged and promoted to live.

@AnthonyDGreen
Copy link
Contributor

I followed the links. LGTM. I had hoped to break out Overload resolution into its own page since that topic gets a lot of interest. But I don't imagine that would be a problem to add later, right?

@BillWagner BillWagner merged commit d9fca76 into dotnet:master Jul 22, 2017
@BillWagner
Copy link
Member Author

@AnthonyDGreen You are correct, responding to changes will be easy. I'm watching the VBLang repo, so I should see when you make that update. Just to be sure, if you @ mention me, I'll make sure to update the published spec when I see it.

@BillWagner BillWagner deleted the publish-vb-language-spec branch July 31, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants