Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated rules on how to use target framework #27939

Merged
merged 2 commits into from
Jan 24, 2022
Merged

updated rules on how to use target framework #27939

merged 2 commits into from
Jan 24, 2022

Conversation

vlada-shubina
Copy link
Member

Follow up on #25603

  • test templates are not shipped to NuGet, so earlier target frameworks can only be changed by installing additional SDK.
  • removed statement for WPF - they are shipping all supported frameworks inside one pack (as winforms)
  • adjusted versions, removed out-of-support versions

@dotnet-bot dotnet-bot added this to the January 2022 milestone Jan 24, 2022
tdykstra
tdykstra approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left some suggestions.

baronfel
baronfel approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concur with @tdykstra's suggestions, gotta keep that branding consistent :)

@vlada-shubina @tdykstra
Apply suggestions from code review
3a5c206 
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
@tdykstra tdykstra merged commit 52dcfa5 into dotnet:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

@tdykstra tdykstra tdykstra approved these changes

@nohwnd nohwnd Awaiting requested review from nohwnd

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees
No one assigned
Labels
cli/subsvc dotnet-fundamentals/svc
Projects
None yet
Milestone
January 2022
Development

Successfully merging this pull request may close these issues.
4 participants
@vlada-shubina @baronfel @tdykstra @dotnet-bot