Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS2017 RC - Project-wide analysis should not be enabled #1856

Closed
dsyme opened this issue Nov 26, 2016 · 6 comments · Fixed by #1855
Closed

VS2017 RC - Project-wide analysis should not be enabled #1856

dsyme opened this issue Nov 26, 2016 · 6 comments · Fixed by #1855
Labels
Area-LangService-API Bug Regression

Comments

@dsyme
Copy link
Contributor

dsyme commented Nov 26, 2016

VS2017 RC currently enabled project-wide analysis based on ParseAndCheckProject and shows red-squiggly errors based on the results

See vsintegration\src\FSharp.Editor\ProjectDiagnosticAnalyzer.fs

This is wrong, because this method checks using saved files on-disk, not the current contents of buffers. This results in erratic, persistent red-squiggly errors being shown in half-edited unsaved files in the IDE.

We should just disable this feature for now
@dsyme dsyme mentioned this issue Nov 26, 2016
Merged
@vasily-kirichenko
Copy link
Contributor

I'm trying to port virtual file system we use in VFPT vasily-kirichenko@5185d76

It tracks open documents and pass to file system dirty buffers content.

I'm stuck on fitting it to MEF as LanguageServer has FSharpChecker as static field.

@vasily-kirichenko
Copy link
Contributor

OK, it seems to work, but ParseAndCheckProject does not call FileSystem :(

@dsyme
Copy link
Contributor Author

dsyme commented Nov 27, 2016

@vasily-kirichenko Can you share your branch?

We may have to delay looking at this until F# 4.2, though it would be great to get a prototype done

@dsyme dsyme changed the title VS2017 RC - Project-wide analysis should only be enabled if checking is against buffers, not saved on-disk files VS2017 RC - Project-wide analysis should not be enabled Nov 27, 2016
@vasily-kirichenko
Copy link
Contributor

vasily-kirichenko commented Nov 27, 2016 •
edited
Loading

@dsyme what do you mean by sharing the branch? I've created a PR from it, do it whatever you want with it #1866

@dsyme
Copy link
Contributor Author

dsyme commented Nov 27, 2016

yes that's what I meant, thanks

dsyme added a commit that referenced this issue Nov 27, 2016
@dsyme
Signature help for VS2017 (#1855)
0988f1f 
This implements signature help (method overload tips and parameter info). #1767. Also fixes #1856

This is mostly just wiring up the necessary things and copying across some of the nitty-gritty detail from the old language service. Some additional information was propagated such as HasParamArrayArg.
@vasily-kirichenko vasily-kirichenko mentioned this issue Jan 9, 2017
Closed
@dsyme dsyme reopened this Jan 9, 2017
@dsyme
Copy link
Contributor Author

dsyme commented Jan 9, 2017

Mistakenly auto-closed

@dsyme dsyme mentioned this issue Feb 9, 2017
Merged
@dsyme dsyme closed this as completed Feb 9, 2017
nosami pushed a commit to xamarin/visualfsharp that referenced this issue Jan 26, 2022
@dsyme
Signature help for VS2017 (dotnet#1855)
3c3d8cb 
This implements signature help (method overload tips and parameter info). dotnet#1767. Also fixes dotnet#1856

This is mostly just wiring up the necessary things and copying across some of the nitty-gritty detail from the old language service. Some additional information was propagated such as HasParamArrayArg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-API Bug Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Signature help for VS2017 dsyme/fsharp
2 participants
@vasily-kirichenko @dsyme