Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .NET-specific min OS versions to build native code for .NET #10659

Closed
Tracked by #44736
rolfbjarne opened this issue Feb 18, 2021 · 4 comments · Fixed by #21441
Closed
Tracked by #44736

Use .NET-specific min OS versions to build native code for .NET #10659

rolfbjarne opened this issue Feb 18, 2021 · 4 comments · Fixed by #21441
Labels
enhancement The issue or pull request is an enhancement estimate-2d iOS Issues affecting iOS macOS Issues affecting macOS performance If an issue or pull request is related to performance
Milestone
.NET 10

Comments

@rolfbjarne
Copy link
Member

rolfbjarne commented Feb 18, 2021 •
edited
Loading

It looks like we're going to drop support for a few older OS versions.

In particular the new min OS versions are going to be:

We have to update our code accordingly to handle this (instead of using the min OS versions defined for legacy Xamarin)
@rolfbjarne rolfbjarne added enhancement The issue or pull request is an enhancement macOS Issues affecting macOS iOS Issues affecting iOS dotnet-pri1 .NET 6: important for stable release labels Feb 18, 2021
@rolfbjarne rolfbjarne added this to the .NET 6 milestone Feb 18, 2021
@spouliot
Copy link
Contributor

spouliot commented Feb 19, 2021 •
edited
Loading

That would be 10.14+ for net6

https://github.com/dotnet/core/blob/main/release-notes/6.0/supported-os.md

@spouliot
Copy link
Contributor

we also need to define/confirm the minimum for Mac Catalyst

it started shipping in 10.15 (so before our minimum Mac) so the (rock bottom) minimum would be 13.0 (since it match the iOS version)

@rolfbjarne
Copy link
Member Author

so the (rock bottom) minimum would be 13.0

Xcode 12.4 doesn't let you select anything lower than 10.15.1/13.2.

IMHO we shouldn't support anything lower than what the current stable Xcode does when our Mac Catalyst support goes to stable.

spouliot pushed a commit to spouliot/xamarin-macios that referenced this issue Mar 9, 2021
Add the minimum OS supported inside platform assemblies metadata
1d7245d 
The minimum OS supported for .net assemblies are specified in
https://github.com/dotnet/core/blob/master/release-notes/6.0/6.0-supported-os.md

The minimum for legacy assemblies are unchanged. However this information
will now be present in the assemblies (and not just in documentation and
code).

This PR partially address dotnet#10659 and possibly dotnet#10728

Fix dotnet#10793
@spouliot spouliot mentioned this issue Mar 9, 2021
Merged
spouliot added a commit that referenced this issue Mar 10, 2021
@spouliot
Add the minimum OS supported inside platform assemblies metadata (#10820
77b3c21 
)

The minimum OS supported for .net assemblies are specified in
https://github.com/dotnet/core/blob/master/release-notes/6.0/6.0-supported-os.md

The minimum for legacy assemblies are unchanged. However this information
will now be present in the assemblies (and not just in documentation and
code).

This PR partially address #10659 and possibly #10728

Fix #10793
@samhouts samhouts mentioned this issue Jul 7, 2021
Closed
32 tasks
@rolfbjarne rolfbjarne modified the milestones: .NET 6, .NET 7 Jan 25, 2022
@rolfbjarne rolfbjarne modified the milestones: .NET 7, .NET 8 Aug 26, 2022
@rolfbjarne rolfbjarne added performance If an issue or pull request is related to performance and removed dotnet-pri1 .NET 6: important for stable release labels Aug 26, 2022
@rolfbjarne rolfbjarne changed the title [.NET 6] Use .NET-specific min OS versions Use .NET-specific min OS versions to build native code for .NET Aug 26, 2022
@rolfbjarne
Copy link
Member Author

This will be easier to implement after we've dropped support for legacy Xamarin, which will happen for Xcode 15, so I'm postponing this until .NET 9.

@rolfbjarne rolfbjarne modified the milestones: .NET 8, .NET 9 Apr 25, 2023
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 27, 2024
@rolfbjarne rolfbjarne mentioned this issue Oct 15, 2024
Merged
haritha-mohan pushed a commit that referenced this issue Oct 19, 2024
@rolfbjarne @haritha-mohan
[StoreKit] Bind AppStore.requestReview. Fixes #21410. (#21441)
a198a87 
The existing Objective-C class to request an App Store review (SKStoreReviewController) is deprecated in Xcode 16+, and it doesn't even work on the corresponding OS versions.

The replacement API is Swift-only, but luckily it's a very simple API (just a static method), so it's possible to bind it manually.

This required a few other changes/improvements:

* Add support for Swift code in our runtime.

* Just to keep the changes to a minimum, bump the min OS version for legacy code to match the .NET min OS versions. This is because our build logic uses the legacy min versions when compiling native code (a more involved fix would be to update all the build logic to build native code to use the .NET min OS versions, but that's not the point of this PR, so I took the easy route). Fixes #10659.

I've tested the method locally, and it seems to work fine, but I've still marked
it as experimental for now. There are no unit tests because calling the method will
put up a dialog, which won't work correctly in unit tests.

Fixes #21410.
Fixes #10659.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue or pull request is an enhancement estimate-2d iOS Issues affecting iOS macOS Issues affecting macOS performance If an issue or pull request is related to performance
Projects
None yet
Milestone
.NET 10
Development

Successfully merging a pull request may close this issue.

[StoreKit] Bind AppStore.requestReview. Fixes #21410. dotnet/macios
2 participants
@rolfbjarne @spouliot