Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enable snapshot tests on Catalyst #25710

Merged
merged 25 commits into from
Dec 18, 2024
Merged

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Enable snapshot tests on Catalyst.

@jsuarezruiz jsuarezruiz added platform/macOS 🍏 macOS / Mac Catalyst area-testing Unit tests, device tests labels Nov 6, 2024
@github-actions github-actions bot force-pushed the uitest-snapshot-tests-mac branch from 88fe4f0 to e5d66e1 Compare November 7, 2024 12:04
@jsuarezruiz
Copy link
Contributor Author

/rebase

@github-actions github-actions bot force-pushed the uitest-snapshot-tests-mac branch from fdabb2a to cc18960 Compare November 7, 2024 14:25
Copy link
Contributor Author

@jsuarezruiz jsuarezruiz Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior from the Buttons is incorrect, same as on iOS actually. Will be fixed by #25373
After merge that PR, this snapshot must be updated.

@jsuarezruiz jsuarezruiz marked this pull request as ready for review November 12, 2024 08:25
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner November 12, 2024 08:25
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has conflicts now, sorry!

@jfversluis jfversluis merged commit 19dcdcd into main Dec 18, 2024
104 checks passed
@jfversluis jfversluis deleted the uitest-snapshot-tests-mac branch December 18, 2024 07:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests platform/macOS 🍏 macOS / Mac Catalyst
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants