Fixed Net 8: Page and control Unloaded events firing on iOS when navigating to another page #25852
Conversation
NirmalKumarYuvaraj
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-21916
branch
from
07004e9 to
3895e96
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| @@ -0,0 +1,28 @@ | |||
| #if !ANDROID && !MACCATALYST | |||
There was a problem hiding this comment.
Why avoid Android? Could be nice to test the same behavior in all the platforms.
There was a problem hiding this comment.
On the Android platform, the Unloaded event of the current page is not triggered when navigating to the next page. As a result, the UI test case for Android has been skipped. Let me know if you have any further concerns.
Android issue link : #26050
There was a problem hiding this comment.
Could you include a comment and the link to the issue?
There was a problem hiding this comment.
@jsuarezruiz , here is the link to the issue - #26050
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
sheiksyedm
added
the
partner/syncfusion
|
/rebase |
github-actions
bot
force-pushed
the
fix-21916
branch
from
706c25d to
6f84269
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
I tried a few different ways to fix this. I'm never a fan of fixing something by just invoking back to the main thread but I'm not really sure how else to resolve this currently. One thought I had was that if we just stopped firing unloaded when the view is still part of the xplat tree that would be one way where the number of i created an issue here for .NET 10 that we can look at which might generally make loaded/unloaded operate more consistently between platforms |
|
Issue Details:
On the iOS platform, the Loaded and Unloaded events of the current page are triggered twice when navigating to another page.
Root Cause:
The MovedToWindow method in the MauiView class is called twice when page navigation occurs with animation enabled. This behavior causes the _movedToWindow event to be repeatedly wired and unwired, which sequentially triggers the Loaded and Unloaded events.
Description of Change:
To resolve the issue, I moved the UnloadedCheck and OnLoadedCheck methods to the UI thread. This change ensures that calls are queued on the UI thread, allowing the Loaded and Unloaded events to trigger correctly once the UIView is attached to a window. Additionally, I removed redundant code for wiring the Loaded and Unloaded events, as the MovedToWindow method will handle these triggers for all MauiView instances upon attachment to and detachment from the window, with the events firing directly from _movedToWindow.
Tested the behaviour in the following platforms.
Reference
https://stackoverflow.com/questions/34484518/willmovetowindow-is-called-twice
Issues Fixed
Fixes #21916
Screenshots
Before Issue Fix
before.2.mov
After Issue Fix
after.2.mov