Take steps to avoid threadpool starvation #11275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #11160 |
|
/azp run |
|
Pull request contains merge conflicts. |
SimaTian
reviewed
Jan 22, 2025
src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs
Show resolved
Hide resolved
SimaTian
reviewed
Jan 22, 2025
src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs
Show resolved
Hide resolved
SimaTian
reviewed
Feb 18, 2025
|
I've pushed some tweaks involving channels and setting up a drain thread in a slightly different manner - the old construct of |
Erarndt
commented
Feb 18, 2025
SimaTian
force-pushed
the
dev/erarndt/threadUtilization
branch
from
6bd3585 to
56bee6b
Compare
|
I've removed my experimental changes for now. Let's aim to review & merge this, then return to it at a later date. |
SimaTian
approved these changes
Feb 21, 2025
AR-May
approved these changes
Feb 21, 2025
|
I implemented the changes I suggested, @SimaTian please review again. |
SimaTian
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
There are a handful of areas where threadpool threads are unnecessarily blocked by synchronous work, or there is additional contention that can be avoided. The most egregious instance is the synchronous read in BuferedReadStream
The outer call to BeginRead() ends up calling BufferedReadStream.Read() which synchronously blocks when _innerStream.Read() is called. This results in a substantial amount of block time for threadpool threads.
Changes Made
Testing
Notes