-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building slnf with @ in the path #11421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, str2) because it is not available for .net framework
Could this PR maybe also fix #11442? |
This is probably not related. The bug that this PR fixes is not recent and existed before. The one you described looks like a regression. Nevertheless, we will fix it soon. Thanks for reporting! |
hmm too bad but thank you for your time and feedback :) |
YuliiaKovalova
approved these changes
Mar 4, 2025
maridematte
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #11050
If the path to the solution file contains
@
, it builds normally. But, if solution filter references this solution then the build fails:same happens with other symbols like
%
and$
.See the issue description for more details.
Details
The problem occurs on this line:
msbuild/src/Build/Construction/Solution/SolutionFile.cs
Line 661 in a1c2e74
FileUtilities.GetFullPath
changes@
to%40
.Specifically this happens here:
msbuild/src/Shared/FileUtilities.cs
Line 762 in 18c6b2e
Changes
Added
bool escape
param toFileUtilities.GetFullPath
to be able to skip escape for getting solution path from solution filter (.slnf) jsonTesting
Added new test to cover this scenario