Hide ephemeral ProjectRootElements from import enumerations #11474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surayya-MS
approved these changes
Feb 24, 2025
rainersigwald
changed the title
Some project systems (C++/CLI) use the list of imports for a project in the list of fast-up-to-date checks. Because SDK-resolver ephemeral property-definition files were listed as imports but never existed on disk, C++/CLI projects were never considered up to date. Fixes - https://developercommunity.visualstudio.com/t/CCLI-projects-are-always-built-since-/10847695 - https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2381505
rainersigwald
force-pushed
the
exp/mark-ephemeral-and-dont-report
branch
from
0270808 to
94c8211
Compare
baronfel
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item (Internal use): AB#2381505
Summary
Hides the in-memory-only
.propsfile synthesized to support properties returned from an SDK resolver.Customer Impact
All C++/CLI builds in Visual Studio are marked as "not up to date", slowing customer builds.
Regression?
Yes. Experience regressed in 17.13 after dotnet/sdk#45364, which revealed this latent MSBuild bug (introduced in #5269 in 2020).
Testing
Automated tests and manual C++/CLI VS scenario testing.
Risk
Low: changes behavior only for elements that use the new flag adopted in #11478.