Run EndToEnd tests in a more isolated/controlled environment #62433
Conversation
| { | ||
| if (Regex.IsMatch(name, pattern.Trim('\'', '"'))) | ||
| { | ||
| continue; |
| { | ||
| /// <summary> | ||
| /// The EndToEnd tests are isolated from other compiler test to avoid other tests and random |
There was a problem hiding this comment.
Rather than a doc comment, consider putting a README.md in the directory that details this. It shows up better when looking in GitHub.
There we can detail all of the elements we are trying to isolate because they can impact our stress points. Specifically:
- JIT ordering
- GC side effects
- Implicit caching
- Starting stack size #Resolved
| </ItemGroup> | ||
| <ItemGroup> |
There was a problem hiding this comment.
| </ItemGroup> | |
| <ItemGroup> |
| </ItemGroup> | ||
| <ItemGroup> |
There was a problem hiding this comment.
| </ItemGroup> | |
| <ItemGroup> |
Don't need all this ItemGroup separation, just makes the file bigger
| <ItemGroup> | ||
| </ItemGroup> |
There was a problem hiding this comment.
| <ItemGroup> | |
| </ItemGroup> |
eng/build.ps1
Outdated
| @@ -62,6 +62,7 @@ param ( | |||
| [switch][Alias('test')]$testDesktop, | |||
| [switch]$testCoreClr, | |||
| [switch]$testCompilerOnly = $false, | |||
| [switch]$testCompilerEndToEndOnly = $false, | |||
There was a problem hiding this comment.
Why do we need a separate switch? The test parallelization code has a granularity of class. That means a unit test assembly with a single class will always be run as a complete unit. Unsure why we need a separate runner here.
Basically this switch is no different than running dotnet test in the EndToEnd directory. Not sure it's worth the cost to our build infrastructure.
There was a problem hiding this comment.
@jcouv didn't see an answer to this.
There was a problem hiding this comment.
I've removed the testCompilerEndToEndOnly from the public surface area of this script
There was a problem hiding this comment.
@jaredpar Reverted changes to build.ps1. Thanks
|
@jaredpar @RikkiGibson Pleast take another look. Thanks |
|
@jaredpar Please take another look. Thanks |
ghost
added this to the 
After this is merged, I'm going to take a stab at raising limits up again.