Apply changes directly to text buffer - take 2 #62617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonmalinowski PTAL |
genlu
reviewed
Jul 13, 2022
| @@ -246,10 +250,10 @@ public void UpdateText(SourceText newText) | |||
| } | |||
| } | |||
|
|
|||
| private IEnumerable<TextChange> FilterTextChanges(SourceText originalText, List<TextSpan> editorVisibleSpansInOriginal, IReadOnlyList<TextChange> changes) | |||
| private IEnumerable<TextChange> FilterTextChanges(SourceText originalText, List<TextSpan> editorVisibleSpansInOriginal, IEnumerable<TextChange> changes) | |||
There was a problem hiding this comment.
it's unfortunate we have to widen it to IEnumerable, is it possible to keep it a IReadOnlyList?
There was a problem hiding this comment.
Why is that? Seems unnecessary to require a list.
genlu
approved these changes
Jul 13, 2022
ghost
added this to the
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 18, 2022
* upstream/main: (40 commits) Revert "Generalize RoamingProfileStorageLocation to ClientSettingsStorageLocation (dotnet#62684)" Revert "Update SymReader to the latest version (dotnet#62695)" Apply changes directly to text buffer - take 2 (dotnet#62617) Allow diagnostic tagging to use either push or pull diagnostics Tests test and more tests Fix new rename showing overloads when not applicable (dotnet#62559) Add stronger type safety Add support for resolving contextual error types Pass LineFormatting options into OmniSharpCodeAction options Initial approach to supporting contextual types Update dependencies from https://github.com/dotnet/arcade build 20220715.4 (dotnet#62704) Handle diff3 conflict markers (dotnet#62391) Update SymReader to the latest version (dotnet#62695) Generalize RoamingProfileStorageLocation to ClientSettingsStorageLocation (dotnet#62684) Add IWorkspaceProjectContextFactory F# wappers (dotnet#62646) Use OmniSharp LineFormatting fallback options in more places. Remove dependency on Microsoft.VisualStudio.RemoteControl assembly from Features (dotnet#62655) Add array initialization optimization (dotnet#62392) [main] Update dependencies from dotnet/arcade (dotnet#62597) Keep selection on rename invocation (dotnet#62654) ...
adamperlin
pushed a commit
to adamperlin/roslyn
that referenced
this pull request
Jul 19, 2022
* Revert "Revert "Apply changes directly to text buffer (dotnet#62337)" (dotnet#62589)" This reverts commit 0a39dcf. * Apply changes to ContainedDocument subject buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hook up Venus custom buffer change pre- and post-processing.
Previously this was triggered via
Workspace.TryApplyChanges.Validation: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/410945