Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][aot] Microsoft.VisualBasic.Tests.FileSystemTests failing due to use of Assembly.GetCallingAssembly #53815

Open
radical opened this issue Jun 7, 2021 · 1 comment
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono wasm-aot-test WebAssembly AOT Test
Milestone

Comments

@radical
Copy link
Member

radical commented Jun 7, 2021

With #52883 Microsoft.VisualBasic.Tests.FileSystemTests` started to fail with:

[18:33:08] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.Write_ArgumentException
[18:33:08] info: System.IO.IOException : Bad file name or number.
[18:33:08] info:    at Microsoft.VisualBasic.FileSystem.Write(Int32 , Object[] )
[18:33:08] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.<>c__DisplayClass21_0.<Write_ArgumentException>b__0()
[18:33:08] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.AssertThrows[ArgumentException](Action action)
[18:33:08] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[18:33:08] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.FileClose
[18:33:08] info: Assert.Equal() Failure
[18:33:08] info: Expected: 2
[18:33:08] info: Actual:   1
[18:33:08] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[18:33:08] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.FileOpen
[18:33:08] info: Assert.Throws() Failure
[18:33:08] info: Expected: typeof(System.IO.IOException)
[18:33:08] info: Actual:   (No exception was thrown)
[18:33:08] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.AssertThrows[IOException](Action action)
[18:33:08] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[18:33:27] info: Finished:    Microsoft.VisualBasic.Core.Tests.dll
[18:33:27] info: 
[18:33:27] info: === TEST EXECUTION SUMMARY ===

@vargaz said:

The Microsoft.VisualBasic failures seem to be related to calls made to Assembly.GetCallingAssembly () which is not supported in wasm+aot, not sure why this worked previously.

@radical radical added arch-wasm WebAssembly architecture area-Codegen-AOT-mono wasm-aot-test WebAssembly AOT Test labels Jun 7, 2021
@ghost
Copy link

ghost commented Jun 7, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

With #52883 Microsoft.VisualBasic.Tests.FileSystemTests` started to fail with:

[18:33:08] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.Write_ArgumentException
[18:33:08] info: System.IO.IOException : Bad file name or number.
[18:33:08] info:    at Microsoft.VisualBasic.FileSystem.Write(Int32 , Object[] )
[18:33:08] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.<>c__DisplayClass21_0.<Write_ArgumentException>b__0()
[18:33:08] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.AssertThrows[ArgumentException](Action action)
[18:33:08] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[18:33:08] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.FileClose
[18:33:08] info: Assert.Equal() Failure
[18:33:08] info: Expected: 2
[18:33:08] info: Actual:   1
[18:33:08] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[18:33:08] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.FileOpen
[18:33:08] info: Assert.Throws() Failure
[18:33:08] info: Expected: typeof(System.IO.IOException)
[18:33:08] info: Actual:   (No exception was thrown)
[18:33:08] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.AssertThrows[IOException](Action action)
[18:33:08] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[18:33:27] info: Finished:    Microsoft.VisualBasic.Core.Tests.dll
[18:33:27] info: 
[18:33:27] info: === TEST EXECUTION SUMMARY ===

@vargaz said:

The Microsoft.VisualBasic failures seem to be related to calls made to Assembly.GetCallingAssembly () which is not supported in wasm+aot, not sure why this worked previously.

Author: radical
Assignees: -
Labels:

arch-wasm, area-Codegen-AOT-mono, wasm-aot-test

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 7, 2021
@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Jun 14, 2021
@radical radical removed the untriaged New issue has not been triaged by the area owner label Jun 15, 2021
@lewing lewing modified the milestones: 6.0.0, 7.0.0 Aug 4, 2021
radical added a commit to radical/runtime that referenced this issue Mar 25, 2022
And re-enable `System.Text.RegularExpressions.Unit.Tests`

Fixes dotnet#53815
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Mar 25, 2022
@lewing lewing modified the milestones: 7.0.0, Future Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono wasm-aot-test WebAssembly AOT Test
Projects
None yet
Development

No branches or pull requests

3 participants