-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Mono Android sample on Helix #45109
Merged
MaximLipnin
merged 9 commits into
dotnet:master
from
MaximLipnin:run_android_sample_on_helix
Dec 11, 2020
Merged
Run Mono Android sample on Helix #45109
MaximLipnin
merged 9 commits into
dotnet:master
from
MaximLipnin:run_android_sample_on_helix
Dec 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0607292
to
849bda9
Compare
This was referenced Nov 23, 2020
ccc1db8
to
9e082d8
Compare
This was referenced Nov 25, 2020
9e082d8
to
e3dfd57
Compare
e3dfd57
to
698473f
Compare
At the moment it requires arcade helix sdk bump to, at least, version="6.0.0-beta.20576.1". |
698473f
to
82bea5f
Compare
According to the CI log, the sample runs as expected:
|
steveisok
approved these changes
Dec 4, 2020
@akoeplinger Please give this a review |
naricc
reviewed
Dec 8, 2020
fanyang-mono
reviewed
Dec 8, 2020
naricc
approved these changes
Dec 8, 2020
akoeplinger
reviewed
Dec 9, 2020
82bea5f
to
564a68e
Compare
564a68e
to
6864d16
Compare
|
akoeplinger
approved these changes
Dec 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #43865