-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Add functional tests for the supported platforms #46286
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsPart of #43865
|
4e782c9
to
272bf21
Compare
src/tests/FunctionalTests/iOS/Simulator/Interpreter/iOS.Simulator.Interpreter.Test.csproj
Outdated
Show resolved
Hide resolved
src/tests/FunctionalTests/iOS/Simulator/Interpreter/iOS.Simulator.Interpreter.Test.csproj
Outdated
Show resolved
Hide resolved
Putting the functional tests under
It has to be adjusted in some way. |
e7143f7
to
b517a8e
Compare
cf7d734
to
8969215
Compare
src/mono/netcore/sample/wasm/browser/Wasm.Browser.Sample.csproj
Outdated
Show resolved
Hide resolved
Many
To not need all the duplicate copies of |
Thanks, it sounds reasonable to avoid duplication in the source code. But I'm not sure what those test are going to be like after all, so for the sake of simplicity I'd prefer to have its own source for every particular test for now. |
81a2981
to
fa0bc34
Compare
<Import Project="..\..\common.props" /> | ||
|
||
<!-- Redirect 'dotnet publish' to in-tree runtime pack --> | ||
<Target Name="TrickRuntimePackLocation" AfterTargets="ProcessFrameworkReferences"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in a common targets like the other platforms.
<Project> | ||
|
||
<!-- Redirect 'dotnet publish' to in-tree runtime pack --> | ||
<Target Name="TrickRuntimePackLocation" AfterTargets="ProcessFrameworkReferences"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have this in a common to all platforms targets file and then just set a property in each project with whatever the PackageDirectory
value is. Feels nit picky though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of a couple small nits, looks good. I would add Android AOT in a follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I think my comments can be addressed in a follow up PR. |
cc @eerhardt fyi |
Just noticed that we have these functional tests under src/tests but run them as part of the libraries test build:
What was the reason for not just moving them into src/libraries? |
@ViktorHofer as far as I can remember the plan was to untangle the dependency on the libraries test infra but it apparently never happened :) |
Part of #43865
The functional tests:
src/tests/FunctionalTests
directory.src/tests