Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the sdk msi bundles inside the VMR on windows BuildPass=2 verticals #47397

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 9, 2025

Fixes dotnet/source-build#4777

The msi bundle depends on artifacts from other windows verticals. Therefore, it needs to be generated in a BuildPass=2 vertical in the VMR.

Update the existing BuildPass2 verticals and add the win-arm64 one. Update the logic to set a Boolean property that decides whether only the sdk bundle should be generated in redist-installer.proj.

Update existing code so that GenerateMsis.targets doesn't not depend on other targets files aside form the newly introduce RestoreLayout.targets.


This approach (introducing a new boolean) is the fastest one to unblock the missing sdk msi bundle generation in the VMR. It has a few downsides:

  • The boolean makes the existing code slightly harder to follow

After this is merged and we have time, it would be ideal to componentize some parts into separate projects.

…rticals

Fixes dotnet/source-build#4777

The msi bundle depends on artifacts from other windows verticals.
Therefore, it needs to be generated in a BuildPass=2 vertical in the VMR.

Update the existing BuildPass2 verticals and add the win-arm64 one.
Update the logic to set a Boolean property that decides whether
only the sdk bundle should be generated in redist-installer.proj.

Update existing code so that GenerateMsis.targets doesn't not depend
on other targets files aside form the newly introduce RestoreLayout.targets.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 9, 2025
@ViktorHofer
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@ViktorHofer
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build (just) the sdk bundle in sdk BuildPass=2 for win-x64, win-x86, win-arm64
1 participant