Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked asset comparison #47428

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Mar 10, 2025

The idea here was to rewrite the asset comparison in C# (with a little help from CoPilot), and rework into stages:

  1. Map the non-VMR assets to VMR assets.
  2. Analyze the mapping
  3. Write results

I also took advantage of a few key bits of functionality in arcade:

  • The nuget info generator to get version information (vs. trying to extract from the file name)
  • The version identifier for blobs, so that we can strip version information from the path, then attempt to find a file matching the stripped name in the VMR assets.

In the second phase, I started with the existing tests, but we can move the other tests (comparing NuGet content) over here. Those are also written in C# so it should be simpler.

I also changed the output to an xml file, with entries corresponding to mappings, and lists of issues.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 10, 2025
@mmitche mmitche requested a review from wtgodbe March 10, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant