Keep IPrincipal user instances if not ClaimsPrincipal #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are instances where people are using non-ClaimsPrincipal users in ASP.NET Core. This change will allow us to track that IPrincipal and surface it as needed as a ClaimsPrincipal. This is mostly for use while migrating, as ideally they will switch to a ClaimsPrincipal based User, but will prevent information contained in the custom type from being lost.
Tratcher
approved these changes
May 26, 2023
| { | ||
| null => null, | ||
| ClaimsPrincipal claims => claims, | ||
| IPrincipal user => new ClaimsPrincipal(user), |
There was a problem hiding this comment.
For now, I don't think we need to. It's only used here in the case of a custom IPrincipal, which should be a somewhat fringe case and one we'd like them to move away from. I'll add some logging to flag these cases to le people know, as well as add a section in the docs to explain in more detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are instances where people are using non-ClaimsPrincipal users in ASP.NET Core. This change will allow us to track that IPrincipal and surface it as needed as a ClaimsPrincipal.
This is mostly for use while migrating, as ideally they will switch to a ClaimsPrincipal based User, but will prevent information contained in the custom type from being lost.