Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setter for HttpContext.Current #416

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

afshinm
Copy link
Contributor

@afshinm afshinm commented Oct 9, 2023

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
Add a setter for HttpContext.Current

PR Description

Looking at the System.Web implementation, it seems like HttpContext.Current is not read-only https://github.com/microsoft/referencesource/blob/master/System.Web/HttpContext.cs#L566-L579 which is different than our implementation https://github.com/dotnet/systemweb-adapters/blob/main/src/Microsoft.AspNetCore.SystemWebAdapters/HttpContext.cs#L31

Addresses #400

Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @afshinm

@twsouthwick twsouthwick enabled auto-merge (squash) October 9, 2023 19:39
@twsouthwick twsouthwick merged commit 45318dc into dotnet:main Oct 9, 2023
@afshinm afshinm deleted the amehrabani/httpcontext-setter branch October 9, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants