Add test to verify method signature of adapted types #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out there are a few types we didn't port correctly. This adds a test to catch further regressions, as well as to track a baseline of known issues.
7 tasks
joperezr
reviewed
Mar 27, 2024
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Update="BaselineOk.txt"> |
There was a problem hiding this comment.
It's a manual process - i.e. the test identifies a bunch of APIs whose docids don't match. Generally, these are suspect that they won't resolve on framework. These can then be verified that they actually do work, so we can add them to the BaselineOk.txt file
joperezr
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there are a few types we didn't port correctly. This adds a test to catch further regressions, as well as to track a baseline of known issues.