Add HostingEnvironment.ApplicationPhysicalPath/ApplicationVirtualPath #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joperezr
reviewed
Mar 27, 2024
|
|
||
| namespace Microsoft.AspNetCore.SystemWebAdapters; | ||
|
|
||
| public class SystemWebAdaptersOptions | ||
| { | ||
| /// <summary> | ||
| /// Gets or sets the value used by <see cref="HostingEnvironment.ApplicationID"/> |
There was a problem hiding this comment.
Interesting. I see that most of the code doesn't have tripple slash comments, which makes sense as we usually add things here for people that are already using the API, but for this one it makes sense as this is specific about registering the adapters. I wonder if there is a way to enforce docs on public API on the latter bucket but not on the former.
There was a problem hiding this comment.
I'm not aware of anything in that area, but it would be nice
joperezr
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.