Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable nullable for new projects #4922

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Conversation

jmarolf
Copy link
Contributor

@jmarolf jmarolf commented May 16, 2021

resolves dotnet/templates#485
fixes #5171

Microsoft Reviewers: Open in CodeFlow

@jmarolf jmarolf requested a review from a team as a code owner May 16, 2021 23:17
@ghost ghost assigned jmarolf May 16, 2021
RussKie
RussKie previously approved these changes May 16, 2021
@jmarolf jmarolf force-pushed the enable-nullable branch from 69254a3 to c044a72 Compare May 17, 2021 18:22
@dreddy-work
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dreddy-work dreddy-work added this to the 6.0 Preview6 milestone May 18, 2021
@RussKie
Copy link
Member

RussKie commented May 18, 2021

@jmarolf leaving with you to merge when this is ready. Marking as "no merge" so we don't merge it prematurely.

@RussKie RussKie removed this from the 6.0 Preview6 milestone May 18, 2021
@RussKie RussKie added 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) area-Templates labels May 18, 2021
@jmarolf jmarolf merged commit c47d6d2 into dotnet:main Jun 1, 2021
@jmarolf jmarolf deleted the enable-nullable branch June 1, 2021 19:24
@ghost ghost added this to the 6.0 Preview6 milestone Jun 1, 2021
@RussKie RussKie removed the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WinForms project templates use latest C# language idioms Enable nullable by default for new projects
3 participants