-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: closes #13 and implements preview endpoint and logo via base64 in json body arg 'logo' #15
feat: closes #13 and implements preview endpoint and logo via base64 in json body arg 'logo' #15
Conversation
3ea07dc
to
2c228f9
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 33.94% 39.89% +5.95%
==========================================
Files 14 15 +1
Lines 380 396 +16
==========================================
+ Hits 129 158 +29
+ Misses 243 226 -17
- Partials 8 12 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think having "localhost:8080" is easier for people that are just starting since it makes it a no-brainer on how to use the application (the example we have in usage
makes it in a way where localhost:8080
works.) If we end up changing it to https://yourdomain.something
, then we should change it everywhere - which will help regarding consistency.
P.S.: /api/v1/preview
is another endpoint we can add to the http-requests/rest-api.http
file, if you want to add a simple test there :)
I can try to write the test, but is it being used? (the http ones) |
0352cd4
to
7b3dac3
Compare
…n json body arg 'logo'
7b3dac3
to
441ca94
Compare
No description provided.