Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: closes #13 and implements preview endpoint and logo via base64 in json body arg 'logo' #15

Merged

Conversation

bolovsky
Copy link
Member

@bolovsky bolovsky commented Jun 5, 2023

No description provided.

@bolovsky bolovsky added the feature Signals a non existent feature request label Jun 5, 2023
@bolovsky bolovsky requested a review from fmgAndre June 5, 2023 16:44
@bolovsky bolovsky self-assigned this Jun 5, 2023
@bolovsky bolovsky force-pushed the rlopes/issue_13_adds_preview_capability_and_logo_stuffs branch from 3ea07dc to 2c228f9 Compare June 5, 2023 16:47
@bolovsky bolovsky linked an issue Jun 5, 2023 that may be closed by this pull request
@bolovsky bolovsky added this to the 0.2.0 milestone Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 63.04% and project coverage change: +5.95 🎉

Comparison is base (f845171) 33.94% compared to head (441ca94) 39.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   33.94%   39.89%   +5.95%     
==========================================
  Files          14       15       +1     
  Lines         380      396      +16     
==========================================
+ Hits          129      158      +29     
+ Misses        243      226      -17     
- Partials        8       12       +4     
Impacted Files Coverage Δ
service/shorty.go 15.55% <0.00%> (+3.58%) ⬆️
service/qr_code.go 67.44% <67.44%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pedrodsrodrigues pedrodsrodrigues changed the title feat: closes #13 and implementspreview endpoint and logo via base64 i… feat: closes #13 and implementspreview endpoint and logo via base64 in json body arg 'logo' Jun 5, 2023
@pedrodsrodrigues pedrodsrodrigues changed the title feat: closes #13 and implementspreview endpoint and logo via base64 in json body arg 'logo' feat: closes #13 and implements preview endpoint and logo via base64 in json body arg 'logo' Jun 5, 2023
Copy link
Contributor

@pedrodsrodrigues pedrodsrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think having "localhost:8080" is easier for people that are just starting since it makes it a no-brainer on how to use the application (the example we have in usage makes it in a way where localhost:8080 works.) If we end up changing it to https://yourdomain.something, then we should change it everywhere - which will help regarding consistency.

P.S.: /api/v1/preview is another endpoint we can add to the http-requests/rest-api.http file, if you want to add a simple test there :)

@bolovsky
Copy link
Member Author

bolovsky commented Jun 6, 2023

I can try to write the test, but is it being used? (the http ones)

@bolovsky bolovsky force-pushed the rlopes/issue_13_adds_preview_capability_and_logo_stuffs branch 6 times, most recently from 0352cd4 to 7b3dac3 Compare June 19, 2023 10:26
@bolovsky bolovsky force-pushed the rlopes/issue_13_adds_preview_capability_and_logo_stuffs branch from 7b3dac3 to 441ca94 Compare June 19, 2023 10:36
@bolovsky bolovsky merged commit d59cf54 into master Jun 19, 2023
@bolovsky bolovsky deleted the rlopes/issue_13_adds_preview_capability_and_logo_stuffs branch June 19, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Signals a non existent feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview Endpoint
2 participants