Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #16 PATCH endpoint for shorty #18

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

bolovsky
Copy link
Member

@bolovsky bolovsky added the feature Signals a non existent feature request label Aug 18, 2023
@bolovsky bolovsky requested a review from fmgAndre August 18, 2023 10:42
@bolovsky bolovsky self-assigned this Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.46% ⚠️

Comparison is base (d59cf54) 39.89% compared to head (8d21789) 38.44%.

❗ Current head 8d21789 differs from pull request most recent head afad119. Consider uploading reports for the commit afad119 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   39.89%   38.44%   -1.46%     
==========================================
  Files          15       15              
  Lines         396      411      +15     
==========================================
  Hits          158      158              
- Misses        226      241      +15     
  Partials       12       12              
Files Changed Coverage Δ
database/database.go 0.00% <0.00%> (ø)
database/repository.go 0.00% <0.00%> (ø)
service/shorty.go 13.59% <0.00%> (-1.97%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fmgAndre
fmgAndre previously approved these changes Aug 18, 2023
- Creates new PATCH endpoint to allow shorty edition (closes #16)
@bolovsky bolovsky dismissed stale reviews from pedrodsrodrigues and fmgAndre via afad119 August 18, 2023 15:29
@bolovsky bolovsky force-pushed the rlopes/#16_endpoint_for_short_link_edit branch from 8d21789 to afad119 Compare August 18, 2023 15:29
@bolovsky bolovsky merged commit 1680a29 into master Aug 18, 2023
@bolovsky bolovsky deleted the rlopes/#16_endpoint_for_short_link_edit branch August 18, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Signals a non existent feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint for edition of shortlink
3 participants