Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MVC order by related column use alias #1504

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Oct 26, 2020

Description

fix MVC order by related fields (use aliased join)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #1504 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
+ Coverage   72.74%   72.75%   +0.01%     
==========================================
  Files          46       46              
  Lines        6354     6354              
==========================================
+ Hits         4622     4623       +1     
+ Misses       1732     1731       -1     
Flag Coverage Δ
#python 72.75% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/models/sqla/interface.py 78.80% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03fb608...99c7d16. Read the comment docs.

@dpgaspar dpgaspar merged commit 6a4a056 into master Oct 26, 2020
@dpgaspar dpgaspar deleted the fix/order-by-mvc-v2 branch October 26, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant