Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load user info for okta #1589

Merged
merged 1 commit into from
Mar 27, 2021
Merged

fix: load user info for okta #1589

merged 1 commit into from
Mar 27, 2021

Conversation

houqp
Copy link
Contributor

@houqp houqp commented Mar 20, 2021

Description

Fix okta integration

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #1589 (c64c735) into master (dbe1ede) will decrease coverage by 4.73%.
The diff coverage is 88.23%.

❗ Current head c64c735 differs from pull request most recent head c0b8851. Consider uploading reports for the commit c0b8851 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1589      +/-   ##
==========================================
- Coverage   74.76%   70.02%   -4.74%     
==========================================
  Files          46       54       +8     
  Lines        6585     7869    +1284     
==========================================
+ Hits         4923     5510     +587     
- Misses       1662     2359     +697     
Flag Coverage Δ
python 70.02% <88.23%> (-4.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/baseviews.py 89.86% <ø> (ø)
flask_appbuilder/security/manager.py 72.05% <0.00%> (-0.09%) ⬇️
flask_appbuilder/__init__.py 100.00% <100.00%> (ø)
flask_appbuilder/models/filters.py 88.19% <100.00%> (-0.62%) ⬇️
flask_appbuilder/models/sqla/filters.py 76.66% <100.00%> (+5.53%) ⬆️
flask_appbuilder/security/mongoengine/models.py 0.00% <0.00%> (-89.34%) ⬇️
flask_appbuilder/models/mongoengine/interface.py 0.00% <0.00%> (-77.50%) ⬇️
flask_appbuilder/models/mongoengine/filters.py 0.00% <0.00%> (-68.58%) ⬇️
flask_appbuilder/security/mongoengine/manager.py 0.00% <0.00%> (-60.35%) ⬇️
flask_appbuilder/models/mongoengine/fields.py 41.66% <0.00%> (-27.78%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302e4ab...c0b8851. Read the comment docs.

@houqp houqp changed the title fix load user info for okta fix: load user info for okta Mar 20, 2021
@jonathonbattista
Copy link

What is the status on this?

@houqp
Copy link
Contributor Author

houqp commented Mar 23, 2021

waiting for project maintainer to approve and merge, but we are already running this in production :)

@jonathonbattista
Copy link

@houqp How did you go about packaging this?

@houqp
Copy link
Contributor Author

houqp commented Mar 25, 2021

pip install from my own git branch

@thesuperzapper
Copy link
Contributor

@dpgaspar can you review this PR?

Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@dpgaspar dpgaspar merged commit d04ec3c into dpgaspar:master Mar 27, 2021
@jonathonbattista
Copy link

When will a new release be cut?

@dpgaspar
Copy link
Owner

Next week

@thesuperzapper
Copy link
Contributor

@houqp houqp deleted the qp_okta branch March 28, 2021 01:37
@houqp
Copy link
Contributor Author

houqp commented Mar 28, 2021

I don't have the answer because I don't have the environment to test. I recommend giving it a try and file issue to report any bug you found.

@thesuperzapper
Copy link
Contributor

Issue is I don't have any azure setup either!

Anyone who does, please comment!

@dpgaspar
Copy link
Owner

dpgaspar commented Apr 5, 2021

RC1 for 3.2.2 is out: https://pypi.org/project/Flask-AppBuilder/3.2.2rc1/

3.2.2 will be out today/tomorrow

@aliuyusuf003
Copy link

I am using azure oauth provider for superset on my localhost and I am getting this error "'Response' object has no attribute 'data'
"
Can some one point me to the fix. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants