-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load user info for okta #1589
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1589 +/- ##
==========================================
- Coverage 74.76% 70.02% -4.74%
==========================================
Files 46 54 +8
Lines 6585 7869 +1284
==========================================
+ Hits 4923 5510 +587
- Misses 1662 2359 +697
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What is the status on this? |
waiting for project maintainer to approve and merge, but we are already running this in production :) |
@houqp How did you go about packaging this? |
pip install from my own git branch |
@dpgaspar can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix!
When will a new release be cut? |
Next week |
@houqp @dpgaspar do you think we also need to do this for "azure"? |
I don't have the answer because I don't have the environment to test. I recommend giving it a try and file issue to report any bug you found. |
Issue is I don't have any azure setup either! Anyone who does, please comment! |
RC1 for 3.2.2 is out: https://pypi.org/project/Flask-AppBuilder/3.2.2rc1/ 3.2.2 will be out today/tomorrow |
I am using azure oauth provider for superset on my localhost and I am getting this error "'Response' object has no attribute 'data' |
Description
Fix okta integration
ADDITIONAL INFORMATION