Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): register responses with apispec using components.response() #1881

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

jnahmias
Copy link
Contributor

@jnahmias jnahmias commented Jul 3, 2022

responses should be registered with apispec using components.response();
not by directly modifying the _reponses dict, which is internal to the
ApiSpec.Components class.

Also, handle duplicate response registrations gracefully.

responses should be registered with apispec using components.response();
not by directly modifying the _reponses dict, which is internal to the
ApiSpec.Components class.

Also, handle duplicate response registrations gracefully.
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #1881 (243041c) into master (93a446c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1881   +/-   ##
=======================================
  Coverage   77.64%   77.64%           
=======================================
  Files          70       70           
  Lines        8556     8559    +3     
=======================================
+ Hits         6643     6646    +3     
  Misses       1913     1913           
Flag Coverage Δ
python 77.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/api/__init__.py 96.41% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a446c...243041c. Read the comment docs.

@dpgaspar dpgaspar merged commit 449afe4 into dpgaspar:master Jul 5, 2022
@jnahmias jnahmias deleted the fix_apispec_reg_resp branch July 5, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants