Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keycloak OAuth2: get groups as role_keys per default #2235

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: Keycloak OAuth2: get groups as role_keys per default #2235

merged 1 commit into from
May 13, 2024

Conversation

berlincount
Copy link
Contributor

@berlincount berlincount commented May 9, 2024

Description

Small change that makes integrating roles with Keycloak dramatically easier, i.e. stops requiring writing custom code.

(fix not feat because this should have been default and makes indirect usability of the library so much easier for users of Superset and the like)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

Closes #1985

@berlincount berlincount changed the title Keycloak OAuth2: get groups as role_keys per default fix: Keycloak OAuth2: get groups as role_keys per default May 9, 2024
Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thank you

@dpgaspar dpgaspar merged commit a2c91db into dpgaspar:master May 13, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AUTH_ROLES_MAPPING support using Keycloak OAuth
2 participants