Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update layout to allow sub-navigation outside of projects #1351

Open
wants to merge 140 commits into
base: develop
Choose a base branch
from
Open

Update layout to allow sub-navigation outside of projects #1351

wants to merge 140 commits into from

Conversation

nicolachr
Copy link
Contributor

@nicolachr nicolachr commented Mar 17, 2025 •
edited
Loading

Summary

This PR makes the necessary adjustments to the layout, to allow the expansion of the double vertical navigation to other views, and not just in-project. Changes include:

  • renaming instances of instance-nav to main-nav
  • renaming instances of project-nav to sub-nav

Check List

  • Added a CHANGELOG entry

MattBudz and others added 30 commits January 22, 2025 13:39
@MattBudz
prevent tall dashboard due to activity feed
1bf381d
@MattBudz
set view content width using CSS only
260642e
@MattBudz
improve layout pro parity
a9931d6
@MattBudz
remove unneeded class
00fc88f
@MattBudz
improve page titles
e3ab83d
@nicolachr
Add missing CSS for alerts and bg-info. Update nav-link colors
b8fa557
@nicolachr
Accessibility: ensure sufficient contrast ratio
cf323c3
@MattBudz
clean up body tag and improve pro parity
f8870b0
@MattBudz
:alpha hera_helper
b809c20
@MattBudz
DRY
f3eca54
@nicolachr
Ensure that navigation is visible in mobile views
6092e54
@nicolachr
Allocate less vertical space for header when not in-project
c1ea65f
@nicolachr
Adjust sidebar location when not in-project
66f4176
@nicolachr
CSS adjustments for sidebar
b23ccb6
@nicolachr
Typo
537673c
@nicolachr
Move CSS for dataTables to hera
3945969
@nicolachr
Move CSS for buttons to hera
4d663e6
@nicolachr
Button CSS alpha
cfd6c79
@nicolachr
[FIX] broken QA state buton
85a8b4b
@nicolachr
Move editor toolbar to hera
54e7033
@nicolachr
Move CSS for empty state to hera
367f1d9
@nicolachr
[FIX] DataTable columnVisibility padding
3946e65
@nicolachr
Move CSS for icons
11dedcc
@nicolachr
Move mixins to hera
1470404
@nicolachr
Move CSS for notifications to hera
4c6c415
@nicolachr
Copy CSS for pagination to hera
092517d
@nicolachr
Revert "Copy CSS for pagination to hera"
ac1a639 
This reverts commit 092517d.
@nicolachr
Copy CSS for pagination to hera
d95e499
@nicolachr
Move revisions and validations to hera
9ed863b
@nicolachr
Move comments to hera
5c6d46b
MattBudz and others added 30 commits March 6, 2025 16:01
@MattBudz
remove redundant layout definition
f268a26
@MattBudz
avoid specifying ce vs pro partials
d5498b6
@nicolachr
Ensure lists semantics
ea97884
@nicolachr
Ensure dropdown-divider is visible only when there are list items
2222c5e
@nicolachr
Allow more vertical space for dropdown menus
c0b14bf
@nicolachr
Fix rendering tools in a single li element
3bae595
@MattBudz
ensure hera is used post-login
7fa644f
@nicolachr
Ensure textile toolbar is visible when fullscreen
eb4cde3
@MattBudz
Merge branch 'develop' into hera/pro-parity
d32cc3e
@MattBudz
use nested layout to eliminate in_project? check
d4ef128
@MattBudz
fix rubocop failures
618167a
@nicolachr
Update instance_nav to main_nav
b92ad33
@nicolachr
Rename instance_navbar to main_navbar
4ad38da
@nicolachr
Rename instance_nav to main_nav (dir & files)
3512975
@nicolachr
Rename instance-nav to main-nav
86e91c2
@MattBudz
render correct layout for nodes
7db3125
@MattBudz
lint
9a98b6e
@nicolachr
Rename project_nav to sub_nav
a3410a5
@nicolachr
Rename project-nav to sub-nav
dee41b0
@MattBudz
use correct layout for cards
e061521
@MattBudz
lint
4a8e898
@nicolachr
Rename in-project to has-sub-nav
9e078fb
@MattBudz
update after controller_name -> controller_path
2244c3c
@nicolachr
Ensure project layout uses correct names
2a31498
@nicolachr
Merge branch 'hera/pro-parity' into navigation/add-sub-nav
e4c809f
@nicolachr
Ensure correct body class is applied
7919044
@MattBudz
remove pro-only code
46a0b3e
@nicolachr
Merge branch 'hera/pro-parity' into navigation/add-sub-nav
81df246
@MattBudz
:alpha
8548d44
@nicolachr
Merge branch 'hera/pro-parity' into navigation/add-sub-nav
6a2248c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolachr @MattBudz