[pull] trunk from WordPress:trunk #1982
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Props pbearne, costdev, autotutorial, debarghyabanerjee, swissspidy. Fixes #60023. git-svn-id: https://develop.svn.wordpress.org/trunk@59830 602fd350-edb4-49c9-b593-d223f7449a82
…ink()` function. There is no need to support HTML in this string and switching to `innerText` helps facilitate a more restrictive Content Security Policy. Props micromadness, sabernhardt Fixes #58765 git-svn-id: https://develop.svn.wordpress.org/trunk@59831 602fd350-edb4-49c9-b593-d223f7449a82
Remove references to the obsolete style property `clip: rect(1px, 1px, 1px, 1px);` and replace or adapt to use `clip-path: inset(50%);`. Update associated `:focus` styles as appropriate. Remove prefixed instances of `-webkit-clip-path`. Props afercia, hbhalodia, audrasjb, joedolson, sabernhardt. Fixes #62238. git-svn-id: https://develop.svn.wordpress.org/trunk@59832 602fd350-edb4-49c9-b593-d223f7449a82
Follow up to [59749]. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59833 602fd350-edb4-49c9-b593-d223f7449a82
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This changeset resolves an issue where long filenames in the media uploader modal would overflow their container. By adding `word-break: break-all;` to the `.upload-error-filename` class, filenames now properly break into multiple lines. Props kharisblank, audrasjb, sainathpoojary. Fixes #62980. git-svn-id: https://develop.svn.wordpress.org/trunk@59834 602fd350-edb4-49c9-b593-d223f7449a82
…upload-error-filename`. This changeset replaces the `word-break: break-all` CSS declaration added to the `.upload-error-filename` element with the common class `word-wrap-break-word`, for better maintainability. Follow-up to [59834]. Props sabernhardt. Fixes #62980. git-svn-id: https://develop.svn.wordpress.org/trunk@59835 602fd350-edb4-49c9-b593-d223f7449a82
Due to concatenation directly above, this value can only be a string. Follow-up to [28130], [48929]. See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59836 602fd350-edb4-49c9-b593-d223f7449a82
This changeset adds support for the Speculation Rules API and configures it by default to `prefetch` certain links with an eagerness of `conservative`, leading to improved performance by starting to load URLs before the user lands on them. The new `WP_Speculation_Rules` class is a container class representing the set of used speculation rules. By default, WordPress Core will only add a single speculation rule, which results in most links being prefetched conservatively. The behavior of that main speculation rule can be altered by using the new `wp_speculation_rules_configuration` filter, which receives an associative array with `mode` and `eagerness` keys, or `null`. Both `mode` and `eagerness` have a default value of `auto`, which for now will result in the aforementioned behavior. The value `null` is used by default in certain scenarios such as when the current user is logged in. Developers can explicitly provide supported mode values (`prefetch` or `prerender`) and other supported eagerness values (`conservative`, `moderate`, or `eager`) to override and enforce the respective behaviors, or return `null` to disable speculative loading feature (either unconditionally or for certain situations). The Speculative Loading feature plugin for example, which this feature is based on, will make use of this filter to continue to use mode `prerender` and eagerness `moderate` by default. Developers can call the `wp_get_speculation_rules_configuration()` function to check how speculative loading is configured on the WordPress site. Another important filter introduced is `wp_speculation_rules_href_exclude_paths`, which allows to expand the list of URL patterns that are excluded from being prefetched or prerendered per WordPress Core's main speculation rule configuration. Several URL patterns such `/wp-admin/*` (any URL within WP Admin) or `/*\\?(.+)` (any URL that includes query parameters) are already excluded by default. Plugins that use content that would be preferable not to prefetch or prerender can use the filter to provide corresponding URL patterns. More advanced customization is possible by adding further speculation rules that will be loaded in addition to WordPress Core's main speculation rule. This can be achieved via the new `wp_load_speculation_rules` action, which receives the `WP_Speculation_Rules` class instance and can amend it as needed. Props flixos90, westonruter, joemcgill, desrosj, mukesh27, tunetheweb, thelovekesh, adamsilverstein, swissspidy, domenicdenicola, jeremyroman. Fixes #62503. git-svn-id: https://develop.svn.wordpress.org/trunk@59837 602fd350-edb4-49c9-b593-d223f7449a82
Introduce a new function, `apply_block_hooks_to_content_from_post_object`, to colocate the logic used to temporarily wrap content in a parent block (with `ignoredHookedBlocks` information fetched from post meta) alongside the call to `apply_block_hooks_to_content`. Fetching that information from post meta is required for all block types that get their content from post objects, i.e. Post Content, Synced Pattern, and Navigation blocks. Additionally, the newly introduced function contains logic to ensure that insertion of a hooked block into the `first_child` or `last_child` position of a given Post Content block works, even if that block only contains "classic" markup (i.e. no blocks). Props bernhard-reiter, gziolo, mamaduka. Fixes #61074, #62716. git-svn-id: https://develop.svn.wordpress.org/trunk@59838 602fd350-edb4-49c9-b593-d223f7449a82
This change prevents a PHP deprecation notice in the new `apply_block_hooks_to_content_from_post_object()` function, introduced in r59838. Fixes #62716. git-svn-id: https://develop.svn.wordpress.org/trunk@59839 602fd350-edb4-49c9-b593-d223f7449a82
…erator()`. Follow-up to [2894], [34106], [34250], [34252], [35339]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59840 602fd350-edb4-49c9-b593-d223f7449a82
…tauthor()`. Follow-up to [2894], [34106], [34250], [34545], [36119]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59841 602fd350-edb4-49c9-b593-d223f7449a82
This change updates the Left-aligned Large Quote pattern to use the quote block instead of paragraph blocks. Props flairwebtechnologies, sabernhardt, karmatosed, wpeople, poena, nithins53, balub, sukhendu2002, dilip2615, itpathsolutions, shraddhagore, shailu25. Fixes #61765. git-svn-id: https://develop.svn.wordpress.org/trunk@59842 602fd350-edb4-49c9-b593-d223f7449a82
This change updates the padding, line height, and text color of the button in the file block, so that the styling is not overriden by the link styles. Props poena, sainathpoojary, mai21, parthvataliya, devtanbir, ankitkumarshah, sabernhardt, shailu25. Fixes #62793. git-svn-id: https://develop.svn.wordpress.org/trunk@59843 602fd350-edb4-49c9-b593-d223f7449a82
Remove a limitation that prevented PNG uploads from generating the full sized image. Fixes a bug where using the image_editor_output_format filter would not generate full sized images as expected. The removed code was present to prevent overly large PNG image output, however this issue was resolved separately in #36477. Props: adamsilverstein, pixlpirate, flixos90, mukesh27, azaozz. Fixes #62900. git-svn-id: https://develop.svn.wordpress.org/trunk@59844 602fd350-edb4-49c9-b593-d223f7449a82
Follow up to r59844. Props: mukesh27. See #62900. git-svn-id: https://develop.svn.wordpress.org/trunk@59845 602fd350-edb4-49c9-b593-d223f7449a82
Props viralsampat shailu25, audrasjb. Fixes #62750. git-svn-id: https://develop.svn.wordpress.org/trunk@59846 602fd350-edb4-49c9-b593-d223f7449a82
…ncy. This changeset brings more consistency by capitalizing the "Collapse Menu" string localted in the main admin menu. Props alireyad, bijit027, amimulihsanmahdi, csesumonpro. Fixes #59133. git-svn-id: https://develop.svn.wordpress.org/trunk@59847 602fd350-edb4-49c9-b593-d223f7449a82
`wp-prettier` was out of date and no longer compatible with wp-scripts. Additionally, many generated files and plugins were not being properly ignored which could cause linting to take so long that it was basically unusable. Props ankitkumarshah, jorbin. See #62935. git-svn-id: https://develop.svn.wordpress.org/trunk@59848 602fd350-edb4-49c9-b593-d223f7449a82
… better consistency. Follow-up to [59847]. Props swissspidy. Fixes #59133. git-svn-id: https://develop.svn.wordpress.org/trunk@59849 602fd350-edb4-49c9-b593-d223f7449a82
This changeset brings more consistency by capitalizing the "Edit Site" strings located in the Toolbar and on the Site Editor screen. Props bronsonquick, sabernhardt, audrasjb, peterwilsoncc, adamsilverstein. Fixes #62971. git-svn-id: https://develop.svn.wordpress.org/trunk@59850 602fd350-edb4-49c9-b593-d223f7449a82
…paginated navigation. This changeset replaces `array_map( 'urlencode', $query_args )` with `urlencode_deep( $query_args )` in `twentyfourteen_paging_nav()` to prevent a fatal error when an array is provided in the query vars. Props takayukister, pratiklondhe, rinkalpagdar. Fixes #62972. git-svn-id: https://develop.svn.wordpress.org/trunk@59851 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [3271], [47219]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59852 602fd350-edb4-49c9-b593-d223f7449a82
This changeset enhances the filesystem checks in the Site Health debug data by addressing the following: - Existence Check: Before checking if the fonts directory is writable, it first verifies whether the directory exists. - Improved Messaging: If the fonts directory does not exist, the debug output now reflects this scenario as "Does not exist". If the directory exists, it shows whether it is writable or not. Props zodiac1978, samiamnot, sainathpoojary, abcd95, ankitkumarshah, im3dabasia1. Fixes #62633. git-svn-id: https://develop.svn.wordpress.org/trunk@59853 602fd350-edb4-49c9-b593-d223f7449a82
Add the `:focus-visible` pseudo selector as a valid element in the `theme.json` schema. See also WordPress/gutenberg#68521. Props huubl, audrasjb, poena, sabernhardt, afercia, annebovelett. Fixes #62906. git-svn-id: https://develop.svn.wordpress.org/trunk@59854 602fd350-edb4-49c9-b593-d223f7449a82
Add support handling an empty string in the `$suffix` parameter that allows a file name to be generated with no suffix added. This makes it possible to avoid adding irrelevant suffixes in cases like converting image formats. Props azaozz, debarghyabanerjee, joedolson. See #62359. Fixes #62385. git-svn-id: https://develop.svn.wordpress.org/trunk@59855 602fd350-edb4-49c9-b593-d223f7449a82
On the Twenty Twenty-One theme, this changeset adds `aria-controls` attribute to sub-menu buttons and an `id` to the sub-menu wrapper for additional context on what is being expanded. Props bschneidewind, audrasjb, anandraj346. Fixes #62973. git-svn-id: https://develop.svn.wordpress.org/trunk@59856 602fd350-edb4-49c9-b593-d223f7449a82
Fix the source positioning of the skip link in Twenty Ten and add CSS for visibility on focus. Props anonymized_3085, iammattthomas, joedolson, sabernhardt, shailu25, mukesh27, poena. Fixes #14795. git-svn-id: https://develop.svn.wordpress.org/trunk@59857 602fd350-edb4-49c9-b593-d223f7449a82
Includes: * Using strict comparison and `$wpdb::prepare()`. * Removing one-time variables so that `$wpdb::prepare()` calls are picked up correctly by PHPCS. * Bringing consistency to the type of internal variables, i.e. `$thismonth` and `$thisyear` are both an integer now. Follow-up to [508], [509], [510], [716], [933], [12590], [34463], [44809], [47223], [59908]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59947 602fd350-edb4-49c9-b593-d223f7449a82
Add URL validation in the admin navigation menu manager that matches the validation in the customizer when adding custom links. Improve accessibility of both custom link forms by adding `aria-invalid` and `aria-describedby` attributes with visible error messages and announcing the error using `wp.a11y.speak()`. Props joedolson, nikitasolanki1812, akrocks, pathan-amaankhan, rcreators, ironprogrammer, audrasjb, ankit-k-gupta, chaion07, rinkalpagdar, snehapatil02, jainil07, parthvataliya. Fixes #60619, #60969. git-svn-id: https://develop.svn.wordpress.org/trunk@59948 602fd350-edb4-49c9-b593-d223f7449a82
Site owners likely don't intend for the content of the `readme.html` file to be indexed, as it's unrelated to the site content. Follow-up to [59944]. Props peterwilsoncc, sabernhardt, dd32, audrasjb, abcd95. Fixes #63069. See #63000. git-svn-id: https://develop.svn.wordpress.org/trunk@59949 602fd350-edb4-49c9-b593-d223f7449a82
Move the `updateParentDropdown` and `updateOrderDropdown` methods to be called on the jQuery menu object instead of on the `menus` translations object. Props joedolson, abcd95, audrasjb. Fixes #63059. git-svn-id: https://develop.svn.wordpress.org/trunk@59950 602fd350-edb4-49c9-b593-d223f7449a82
…ate. This changeset fixes both a visual and functional bug related to template selection in the editor that occurred when having a custom block template registered that was using the same slug as another block template already registered by the theme, including the default block templates. Props aljullu, antonvlasenko, apermo, audrasjb, azaozz, ntsekouras. Fixes #62319. git-svn-id: https://develop.svn.wordpress.org/trunk@59951 602fd350-edb4-49c9-b593-d223f7449a82
…` DocBlock. Includes adjusting the `@since` note for the `get_calendar` filter, as the reference is only relevant for the function DocBlock. Follow-up to [59908]. See #62281. git-svn-id: https://develop.svn.wordpress.org/trunk@59952 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [59947]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59953 602fd350-edb4-49c9-b593-d223f7449a82
…ributes. This changeset updates `wp_video_shortcode()` to improve boolean attributes handling in accordance with HTML5 standards. Technically, it replaces `attr="1"` with `attr` for the `loop`, `autoplay` and `muted` attributes. The `preload` attribute is also updated to accept only allowed values: `none`, `metadata`, and `auto`. If a value outside of this list is provided, it will be ignored, preventing invalid attribute outputs. Props jongycastillo, sabernhardt, joedolson, audrasjb, shub07, debarghyabanerjee. Fixes #60178. git-svn-id: https://develop.svn.wordpress.org/trunk@59954 602fd350-edb4-49c9-b593-d223f7449a82
…_audio_shortcode()`. Follow-up to [59954]. See #60178. git-svn-id: https://develop.svn.wordpress.org/trunk@59955 602fd350-edb4-49c9-b593-d223f7449a82
…grade so it remains compatible with versions of WordPress prior to 5.1. The `WP_Error::has_errors()` method was introduced in WordPress 5.1, so this change uses its internal logic instead to remain compatible with earlier versions. Props swissspidy, joemcgill, desrosj. Fixes #63052 git-svn-id: https://develop.svn.wordpress.org/trunk@59956 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [1012], [1737], [48121]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59957 602fd350-edb4-49c9-b593-d223f7449a82
Preloading all blocking requests ensures that the editor canvas becomes responsive quickly and that the browser avoids unnecessary client-side requests. Props mamaduka, joemcgill, audrasjb, peterwilsoncc. Fixes #63050. git-svn-id: https://develop.svn.wordpress.org/trunk@59958 602fd350-edb4-49c9-b593-d223f7449a82
…_offset()` which failed to take into consideration daylight saving time for the `America/St_Johns` timezone. Props debarghyabanerjee, johnbillion, mukesh27, audrasjb. Fixes #63079 git-svn-id: https://develop.svn.wordpress.org/trunk@59959 602fd350-edb4-49c9-b593-d223f7449a82
Change several error message across core to use WordPress standard styling. Ensure only prefixes are wrapped in `strong` tags rather than the whole message, use `notice notice-error` classes where appropriate, and replace a custom error with `wp_admin_notice()` in multisite. Props afercia, rajinsharwar, robinmartijn, mukesh27, sabernhardt, oglekler, joedolson, chaion07, im3dabasia1, audrasjb, dkarfa, najmulsaju. Fixes #50402. git-svn-id: https://develop.svn.wordpress.org/trunk@59960 602fd350-edb4-49c9-b593-d223f7449a82
Syncs @wordpress/* packages to the 'latest' npm tag. Props mamaduka, desrosj, joemcgill. See #62887. git-svn-id: https://develop.svn.wordpress.org/trunk@59961 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [20308], [58360]. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59962 602fd350-edb4-49c9-b593-d223f7449a82
The current `esversion` 6 corresponds to an ECMAScript version from a decade ago (2015). Updating from 6 to 10 allows the following features to be used in Core JS: the exponentiation operator, async functions, shared memory, atomics, asynchronous iteration, rest/spread properties, various RegExp extensions, and optional catch bindings. These features have been supported by all browsers (except for IE11) well beyond WordPress's browser support policy. This also brings Core's allowed ES version closer in line with Gutenberg which is currently using features like async functions. Props westonruter, swissspidy, mukesh27. Fixes #63077. git-svn-id: https://develop.svn.wordpress.org/trunk@59963 602fd350-edb4-49c9-b593-d223f7449a82
… tests. Updates the `external-http` group in the PHPUnit test suite to include all tests that rely on network requests. This is to ensure the main test suite runs do not contain any tests that can fail due to network conditions. Props sukhendu2002, azaozz, audrasjb. Fixes #62325. git-svn-id: https://develop.svn.wordpress.org/trunk@59964 602fd350-edb4-49c9-b593-d223f7449a82
…theme. The active theme(s) now return two additional properties, `default_template_types` and `default_template_part_areas`, in the REST response. Props mamaduka, joemcgill, timothyblynjacobs, audrasjb, gigitux, peterwilsoncc, youknowriad, jorbin. Fixes #62574. git-svn-id: https://develop.svn.wordpress.org/trunk@59965 602fd350-edb4-49c9-b593-d223f7449a82
…ucture. This changeset ensures that pagination links stay consistent with the chosen permalink structure. When the permalink structure uses a trailing slash, pagination permalinks contain one as well, but when the permalink structure doesn't use trailing slash, then pagination links should not use a trailing slash. This makes use of `user_trailingslashit()` with a `paged` value for the `type_of_url` parameter. Props hmbashar, huzaifaalmesbah, rejaulalomkhan, mai21, rahulsprajapati, martinkrcho, ankitkumarshah, adamsilverstein, sourabhjain. Fixes #61393. git-svn-id: https://develop.svn.wordpress.org/trunk@59966 602fd350-edb4-49c9-b593-d223f7449a82
This changeset fixes an issue in multisite installations where archived sites remain accessible to network administrators, but the associated files do not. The previous implementation was checking if the blog is archived, marked as spam, or deleted, to subsequently return a 404 error for file requests. However, this did not account for network administrators who should retain access to these files. Props antwortzeit, jeremyfelt, debarghyabanerjee, audrasjb. Fixes #36803. git-svn-id: https://develop.svn.wordpress.org/trunk@59967 602fd350-edb4-49c9-b593-d223f7449a82
This fixes an issue introduced in [59885] whereby calling `WP_Theme:is_block_theme()` before themes are set up resulted in the parent theme to not be resolved. To address this, post support for editor default-mode has been moved to a standalone callback, `wp_set_editor_default_mode()`, which is called on the `after_setup_theme` hook. In addition, if `WP_Theme::is_block_theme` is called too early, a `_doing_it_wrong()` error will now be thrown. Props fabiankaegy, joemcgill, peterwilsoncc, jorbin, krupajnanda, riddhidave, ugyensupport, navi161, manojmaharrshi, Ankit K Gupta, narenin, shailu25, pooja1210. Fixes #63062. git-svn-id: https://develop.svn.wordpress.org/trunk@59968 602fd350-edb4-49c9-b593-d223f7449a82
Follow up to [59740]. Fixes #62811. git-svn-id: https://develop.svn.wordpress.org/trunk@59969 602fd350-edb4-49c9-b593-d223f7449a82
In [59889] the REST API controllers were adjusted to perform less work when responding to HEAD requests. The WP_REST_Response body would now be `null`, which caused issues with filters that expected the response body to be an array. This commit sets the response body to be an empty array when preparing the response instead. The body will still be discarded, but this provides better backward comppatibility with code that assumes an array will be used. See #56481. Props antonvlasenko, timothyblynjacobs, mamaduka, wildworks. git-svn-id: https://develop.svn.wordpress.org/trunk@59970 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@59971 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@59972 602fd350-edb4-49c9-b593-d223f7449a82
This adds the `new-version` input to the concurrency group name to prevent manually dispatched workflow runs from cancelling each other when different versions are being tested. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59973 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [2894], [28437], [59319]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59975 602fd350-edb4-49c9-b593-d223f7449a82
…ake 1. Follow-up to [4112], [17552], [19918], [20740], [56513], [56656]. Props aristath, poena, afercia, SergeyBiryukov. See #62279. git-svn-id: https://develop.svn.wordpress.org/trunk@59976 602fd350-edb4-49c9-b593-d223f7449a82
This changeset removes the `aria-describedby` attribute when not editing the current user, as no description paragraph is associated. Props kkmuffme, audrasjb, faisal03, shailu25, nandow, eddystile, marineevain, qhaensler, virginienacci. Fixes #63006. git-svn-id: https://develop.svn.wordpress.org/trunk@59978 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )