Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX-61688 fixed out_len value for nullptr #24

Merged
merged 1 commit into from
Jun 20, 2023
Merged

DX-61688 fixed out_len value for nullptr #24

merged 1 commit into from
Jun 20, 2023

Conversation

xxlaykxx
Copy link

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@xxlaykxx xxlaykxx requested a review from DenisTarasyuk June 18, 2023 07:51
@xxlaykxx xxlaykxx merged commit c98bd88 into dremio:dremio-12.0-main Jun 20, 2023
lriggs pushed a commit that referenced this pull request Jul 13, 2023
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (#24)
68e4109
lriggs pushed a commit that referenced this pull request Jul 21, 2023
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (#24)
e922a6b
lriggs pushed a commit that referenced this pull request Jul 28, 2023
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (#24)
01a80c5
xxlaykxx added a commit that referenced this pull request Oct 29, 2023
@xxlaykxx
DX-61688 fixed out_len value for nullptr (#24)
34517b3
DenisTarasyuk pushed a commit that referenced this pull request Dec 19, 2023
@xxlaykxx @DenisTarasyuk
DX-61688 fixed out_len value for nullptr (#24)
fb604dd
DenisTarasyuk pushed a commit that referenced this pull request Jan 16, 2024
@xxlaykxx @DenisTarasyuk
DX-61688 fixed out_len value for nullptr (#24)
fe4bcd0
DenisTarasyuk pushed a commit that referenced this pull request Mar 6, 2024
@xxlaykxx @DenisTarasyuk
DX-61688 fixed out_len value for nullptr (#24)
b87a7f1
lriggs pushed a commit to lriggs/arrow that referenced this pull request Mar 12, 2024
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (dremio#24)
b96ae8d
lriggs pushed a commit to lriggs/arrow that referenced this pull request Apr 25, 2024
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (dremio#24)
06068df
stevelorddremio pushed a commit to stevelorddremio/arrow that referenced this pull request Jun 14, 2024
@xxlaykxx @stevelorddremio
DX-61688 fixed out_len value for nullptr (dremio#24)
db94fd5
lriggs pushed a commit to lriggs/arrow that referenced this pull request Sep 3, 2024
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (dremio#24)
d0521d7
lriggs pushed a commit to lriggs/arrow that referenced this pull request Sep 6, 2024
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (dremio#24)
a5e2bc6
lriggs pushed a commit to lriggs/arrow that referenced this pull request Dec 9, 2024
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (dremio#24)
6a7f8ba
lriggs pushed a commit to lriggs/arrow that referenced this pull request Dec 27, 2024
@pitrou
apacheGH-40633: [C++][Python] Fix ORC crash when file contains unknow…
1e5d6e5 
…n timezone (apache#45051)

### Rationale for this change

If the timezone database is present on the system, but does not contain a timezone referenced in a ORC file, the ORC reader will crash with an uncaught C++ exception.

This can happen for example on Ubuntu 24.04 where some timezone aliases have been removed from the main `tzdata` package to a `tzdata-legacy` package. If `tzdata-legacy` is not installed, trying to read a ORC file that references e.g. the "US/Pacific" timezone would crash.

Here is a backtrace excerpt:
```
dremio#12 0x00007f1a3ce23a55 in std::terminate() () from /lib/x86_64-linux-gnu/libstdc++.so.6
dremio#13 0x00007f1a3ce39391 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6
dremio#14 0x00007f1a3f4accc4 in orc::loadTZDB(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
dremio#15 0x00007f1a3f4ad392 in std::call_once<orc::LazyTimezone::getImpl() const::{lambda()dremio#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()dremio#1}&&)::{lambda()dremio#2}::_FUN() () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
dremio#16 0x00007f1a4298bec3 in __pthread_once_slow (once_control=0xa5ca7c8, init_routine=0x7f1a3ce69420 <__once_proxy>) at ./nptl/pthread_once.c:116
dremio#17 0x00007f1a3f4a9ad0 in orc::LazyTimezone::getEpoch() const ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
dremio#18 0x00007f1a3f4e76b1 in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
dremio#19 0x00007f1a3f4e84ad in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
dremio#20 0x00007f1a3f4e8dd7 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
dremio#21 0x00007f1a3f4e8532 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
dremio#22 0x00007f1a3f4925e9 in orc::RowReaderImpl::startNextStripe() ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
dremio#23 0x00007f1a3f492c9d in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
dremio#24 0x00007f1a3e6b251f in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
```

### What changes are included in this PR?

Catch C++ exceptions when iterating ORC batches instead of letting them slip through.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#40633

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
lriggs pushed a commit to lriggs/arrow that referenced this pull request Feb 13, 2025
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (dremio#24)
9ded1cd
lriggs pushed a commit to lriggs/arrow that referenced this pull request Mar 7, 2025
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (dremio#24)
8b8c48a
lriggs pushed a commit to lriggs/arrow that referenced this pull request Mar 12, 2025
@xxlaykxx @lriggs
DX-61688 fixed out_len value for nullptr (dremio#24)
84707f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lriggs lriggs lriggs approved these changes

@DenisTarasyuk DenisTarasyuk DenisTarasyuk approved these changes

Assignees
No one assigned
Labels
awaiting review Component: C++ - Gandiva Component: C++
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxlaykxx @lriggs @DenisTarasyuk