Convert nested modules to buildable modules

[dan-hughes]

Pull Request (PR) description

Let ModuleBuilder build DhcpServerDsc.Common and DhcpServerDsc.OptionValueHelper.

This Pull Request (PR) fixes the following issues

Task list

• Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
  Entry should say what was changed and how that affects users (if applicable), and
  reference the issue being resolved (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
  help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[dan-hughes]

@johlju, trying to keep the PR's small.

[johlju]

Reviewed 26 of 26 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @dan-hughes)

---

source/Modules/DhcpServerDsc.Common/Public/Get-ValidTimeSpan.ps1 line 1 at r1 (raw file):

# Internal function to translate a string to valid TimeSpan format

Can we add comment-based help to this?

Code quote:

# Internal function to translate a string to valid TimeSpan format

---

tests/Unit/DhcpServerDsc.Common/Public/Assert-ScopeParameter.Tests.ps1 line 43 at r1 (raw file):

    Import-Module -Name $script:subModulePath -Force -ErrorAction 'Stop'

    $PSDefaultParameterValues['InModuleScope:ModuleName'] = $script:subModuleName

Same question as in NetworkingDsc...

Code quote:

$PSDefaultParameterValues['InModuleScope:ModuleName'] = $script:subModuleName

---

source/Modules/DhcpServerDsc.Common/Public/Write-PropertyMessage.ps1 line 1 at r1 (raw file):

# Internal function to write verbose messages for collection of properties

Can we add comment-based help to this?

Code quote:

# Internal function to write verbose messages for collection of properties

---

source/Modules/DhcpServerDsc.Common/Public/New-TerminatingError.ps1 line 2 at r1 (raw file):

# Internal function to throw terminating error with specified ErrorCategory, ErrorId and ErrorMessage
function New-TerminatingError

Can we skip this and use the similar one frpm DscResource.Common? It can be in another PR, can you create an issue in that case?

Code quote:

New-TerminatingError

---

source/Modules/DhcpServerDsc.Common/Public/Get-ValidIPAddress.ps1 line 1 at r1 (raw file):

# Internal function to translate a string to valid IPAddress format

Can we add comment-based help to this?

Code quote:

# Internal function to translate a string to valid IPAddress format

[johlju]

@dan-hughes the HQRM tests (DscResource.Test), for example localization tests, are they run on these private modules? Just curious if I need to be more wary about errors that I could ignored because HQRM would have caught them. 🙂

[dan-hughes]

@dan-hughes the HQRM tests (DscResource.Test), for example localization tests, are they run on these private modules? Just curious if I need to be more wary about errors that I could ignored because HQRM would have caught them. 🙂

Looks to be working looking at the logs.