Add ALTER TABLE support for DuckDB tables #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y--
reviewed
Mar 11, 2025
| @@ -181,6 +187,7 @@ DuckdbHandleDDL(PlannedStmt *pstmt, const char *query_string, ParamListInfo para | |||
| char *access_method = stmt->accessMethod ? stmt->accessMethod : default_table_access_method; | |||
| bool is_duckdb_table = strcmp(access_method, "duckdb") == 0; | |||
| if (is_duckdb_table) { | |||
| pgduckdb::top_level_duckdb_ddl_type = pgduckdb::DDLType::CREATE_TABLE; | |||
There was a problem hiding this comment.
Shouldn't we assert that this is DDLType::NONE before updating it? (same everywhere we update it). Or we're confident this can never happen?
There was a problem hiding this comment.
I'm pretty confident it cannot happen, but I guess it's better safe than sorry. So now it throws an error in that case.
There was a problem hiding this comment.
Should we do the same below (L216?)
Y--
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all ALTER TABLE commands that DuckDB can parse except for COLLATION changes and foreign keys. Not all of these ALTER commands are actually supported by DuckDB (e.g. adding CHECK constraints). But this starts to least forward those queries correctly to DuckDB, so once DuckDB supports it pg_duckdb will start to automatically support it as well.
Fixes #536
Fixes #537
Fixes #538
Fixes #539
Fixes #540
Fixes #541
Fixes #542