Skip to content
This repository was archived by the owner on Sep 11, 2018. It is now read-only.

Fix(karma): Fix Proper incremental test running. #918

Closed
wants to merge 3 commits into from

Conversation

gerbal
Copy link

@gerbal gerbal commented Jul 9, 2016

Resolves #871

Declaring __karmaWebpackManifest__ as a new Arrray() breaks incremental the incremental test runner. As it prevents __karmaWebpackManifest__ from updating with as the webpack manifest changes.

The ugly fast fix is to use an array literal and terminate the statement with a ';' to avoid regressing #709

@gerbal
Copy link
Author

gerbal commented Jul 14, 2016

After further experimentation and exploration, the solution to this one is really easy. Simply excluding test-bundler from test coverage appears to resolve the issue.

@codecov-io
Copy link

codecov-io commented Jul 14, 2016

Current coverage is 70.58% (diff: 100%)

Merging #918 into master will not change coverage

@@             master       #918   diff @@
==========================================
  Files            15         15          
  Lines            85         85          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             60         60          
  Misses           25         25          
  Partials          0          0          

Powered by Codecov. Last update 4370077...d175045

@dvdzkwsk
Copy link
Owner

Looks like this got fixed in another PR (the Array -> [] fix). Not sure the exclude is necessary since we have an explicit include, but if I'm wrong in that please let me know and I can rebase this and merge that fix.

Thanks!

@dvdzkwsk dvdzkwsk closed this Sep 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot/Incremental testing is currently broken
3 participants