-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate transfers form #1555
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
oh wow it actually does use dv4tnt as the gas token. Me thinks we should prob still use USDC so that it is consistent and we can control which gas token to use in the future |
Label for the gas token changes as I fill out the amount input Screen.Recording.2025-03-07.at.8.40.24.AM.mov |
}; | ||
} | ||
|
||
class TransferFormValidationErrors { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should also validate for withdrawGatingInfo and possible withdrawCapacity limits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are only necessary for USDC transfer tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is handled by the useWithdrawalInfo I think. It pops up a window if things are blocked. I talked to teddy and I THINK he said withdrawalCapacity isn't relevant for transfers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but why wouldn't withdrawalCapacity matter? It does a withdrawSubaccountMsg which is the same that we do on actual withdrawals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
teddy said it only applies to the noble thingy, so only if you're taking usdc out via that noble whatchamacallit
No description provided.