Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate transfers form #1555

Merged
merged 7 commits into from
Mar 7, 2025
Merged

feat: migrate transfers form #1555

merged 7 commits into from
Mar 7, 2025

Conversation

tyleroooo
Copy link
Contributor

No description provided.

@tyleroooo tyleroooo marked this pull request as ready for review March 5, 2025 01:04
@tyleroooo tyleroooo requested a review from a team as a code owner March 5, 2025 01:04
Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 5:06pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 5:06pm

@jaredvu
Copy link
Contributor

jaredvu commented Mar 7, 2025

Screenshot 2025-03-07 at 8 34 29 AM

The fees shouldn't have to match the asset being transferred. I think the client defaults to USDC right now and should be displayed as such until we provide the ability for users to use native gas token (This will come a lot later after we fully deprecate old withdraw/deposit flow since Abacus only supports USDC gas atm)

@jaredvu
Copy link
Contributor

jaredvu commented Mar 7, 2025

oh wow it actually does use dv4tnt as the gas token. Me thinks we should prob still use USDC so that it is consistent and we can control which gas token to use in the future

@jaredvu
Copy link
Contributor

jaredvu commented Mar 7, 2025

Label for the gas token changes as I fill out the amount input

Screen.Recording.2025-03-07.at.8.40.24.AM.mov

};
}

class TransferFormValidationErrors {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should also validate for withdrawGatingInfo and possible withdrawCapacity limits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are only necessary for USDC transfer tho

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is handled by the useWithdrawalInfo I think. It pops up a window if things are blocked. I talked to teddy and I THINK he said withdrawalCapacity isn't relevant for transfers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why wouldn't withdrawalCapacity matter? It does a withdrawSubaccountMsg which is the same that we do on actual withdrawals?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teddy said it only applies to the noble thingy, so only if you're taking usdc out via that noble whatchamacallit

@tyleroooo tyleroooo merged commit 9e00e27 into main Mar 7, 2025
9 checks passed
@tyleroooo tyleroooo deleted the tu/migrate-transfers-form branch March 7, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants