Fix visibility of exception classes #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ exceptions which are potentially thrown across DSO boundaries need to have their type info exported. Signed-off-by: Timo Röhling <timo@gaussglocke.de>
roehling
force-pushed
the
fix-exception-visibility
branch
from
326d18a to
74eab5c
Compare
roehling
added a commit
to fkie-forks/Fast-CDR
that referenced
this pull request
Nov 24, 2020
GCC hidden visibility closely mimics the Windows DLL import/export feature, which cleans up the symbol export table and leads to faster startup times as well as a more stable ABI. This PR has no immediate effect until GCC is instructed to hide symbols with -fvisibility=hidden -fvisibility-inlines-hidden. I did not enable this yet because unlike MSVC, GCC does not export type info and vtables by default, so this PR depends on eProsima#88 to work. Signed-off-by: Timo Röhling <timo@gaussglocke.de>
roehling
added a commit
to fkie-forks/Fast-CDR
that referenced
this pull request
Nov 24, 2020
GCC hidden visibility closely mimics the Windows DLL import/export feature, which cleans up the symbol export table and leads to faster startup times as well as a more stable ABI. This PR has no immediate effect until GCC is instructed to hide symbols with -fvisibility=hidden -fvisibility-inlines-hidden. I did not enable this yet because unlike MSVC, GCC does not export type info and vtables by default, so this PR depends on eProsima#88 to work. Signed-off-by: Timo Röhling <timo@gaussglocke.de>
|
Build status:
|
roehling
force-pushed
the
fix-exception-visibility
branch
from
e43ae84 to
1973656
Compare
According to the manual, this warning can be ignored, because std::exception is a type in the C++ Standard Library. https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275?view=msvc-160 Signed-off-by: Timo Röhling <timo@gaussglocke.de>
roehling
force-pushed
the
fix-exception-visibility
branch
from
1973656 to
3ed6c70
Compare
|
Build status:
|
|
Build status:
|
|
I'm closing this, as we will not be tackling it at the moment. I have open #149 to track these ideas, suggestions and comments are most welcomed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ exceptions which are potentially thrown across DSO boundaries need
to have their type info exported.