Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21129] Migrate fastrtps namespace #813

Merged
merged 4 commits into from
Jun 18, 2024
Merged

[21129] Migrate fastrtps namespace #813

merged 4 commits into from
Jun 18, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jun 13, 2024 •
edited by EduPonz
Loading

Description

This PR migrate fastrtps namespace to fastdds. It also rename one of the member of DiscoveryProtocol from NONE to MANUAL.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@elianalf elianalf added this to the v3.0.0 milestone Jun 13, 2024
@elianalf elianalf force-pushed the feature/migrate_fastrtps_namespace branch from b9de67f to 7f2e7bc Compare June 13, 2024 14:02
@elianalf elianalf mentioned this pull request Jun 13, 2024
Merged
9 tasks
elianalf added 4 commits June 17, 2024 11:52
@elianalf
Refs #21129: Migrate fastrtps namespace to fastdds
e6e0a89 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21129: Remove static from DiscoveryProtocol docs
ce7d52d 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21129: Remove DiscoveryProtocol_t typedef
152e5a8 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #21129: Remove typedef ParticipantFilteringFlags_t
1e26ba3 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/migrate_fastrtps_namespace branch from 6bcc5d4 to 1e26ba3 Compare June 17, 2024 10:17
@EduPonz
Copy link

EduPonz commented Jun 17, 2024

@richiprosima please test_3 docs

@EduPonz EduPonz merged commit 79416a6 into master Jun 18, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/migrate_fastrtps_namespace branch June 18, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@elianalf @EduPonz