Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to build Fast DDS with XTypes refactor #116

Merged
merged 12 commits into from
Apr 5, 2024
Merged

Changes to build Fast DDS with XTypes refactor #116

merged 12 commits into from
Apr 5, 2024

Conversation

JLBuenoLopez
Copy link
Contributor

Description

This PR is a miscellaneous containing several changes required to build this package with the Fast DDS branch that refactors XTypes feature.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [NO] Changes are API compatible.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

richiware and others added 9 commits April 3, 2024 07:52
@richiware @JLBuenoLopez
Refs #19960. Apply types header-only
05fe563 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @JLBuenoLopez
Refs #19975. Using new ReturnCode_t
ceaa67b 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@JLBuenoLopez
Refs #20129: update TypeInformationParameter constructor. Define xtyp…
12fb247 
…es namespace and DomainId_t

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #20335: ignore TypeSupport constructor passing a DynamicPubSubType
ae0c6a1 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #20335: regenerate types
3c1b312 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@richiware @JLBuenoLopez
Refs #19451: regenerate types
2c43011 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware @JLBuenoLopez
Refs #19451: Ignore DomainParticipantFactory::get_dynamic_type_builde…
4882db8 
…r_from_xml_by_name

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@JLBuenoLopez
Refs #20734: fixes after rebase
e570745 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez
Refs #20734: remove obsolete file
49ae802 
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez added this to the v2.0.0 milestone Apr 3, 2024
@JLBuenoLopez JLBuenoLopez mentioned this pull request Apr 4, 2024
Merged
10 tasks
richiware added 2 commits April 4, 2024 15:28
@richiware
Refs #20734: Fix some tests
598f64c 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #20734. Fix tests
3e1adec 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
JLBuenoLopez
JLBuenoLopez commented Apr 5, 2024
View reviewed changes
Copy link
Contributor Author

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@richiware
Refs #20734. Regenerate idl dll exporting missing
f87af64 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware force-pushed the feature/remove-cdr branch from 22e90ed to f87af64 Compare April 5, 2024 08:59
JLBuenoLopez
JLBuenoLopez commented Apr 5, 2024
View reviewed changes
@richiware richiware merged commit 8a20026 into 3.0.x-devel Apr 5, 2024
4 checks passed
@richiware richiware deleted the feature/remove-cdr branch April 5, 2024 10:58
EduPonz pushed a commit that referenced this pull request May 14, 2024
@JLBuenoLopez @richiware @EduPonz
Changes to build Fast DDS with XTypes refactor (#116)
334fa3c 
* Refs #19960. Apply types header-only

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19975. Using new ReturnCode_t

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20129: update TypeInformationParameter constructor. Define xtypes namespace and DomainId_t

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20335: ignore TypeSupport constructor passing a DynamicPubSubType

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20335: regenerate types

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #19451: regenerate types

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #19451: Ignore DomainParticipantFactory::get_dynamic_type_builder_from_xml_by_name

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20734: fixes after rebase

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20734: remove obsolete file

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Refs #20734: Fix some tests

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20734. Fix tests

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #20734. Regenerate idl dll exporting missing

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

---------

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Co-authored-by: Ricardo González Moreno <ricardo@richiware.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JLBuenoLopez @richiware