Add sub entities destruction on FastDDS entities #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal DataWriters and DataReaders were not being deleted on Agent FastDDS Publisher and Subscriber delete methods:
Micro-XRCE-DDS-Agent/src/cpp/middleware/fastdds/FastDDSEntities.cpp
Lines 489 to 493 in 904221f
This implies that
delete_publisher
may fail, as explained on FastDDS documentation:This bug caused a thread/memory leak and random response problems using services/clients with reconnection patterns as detected on this issue.
It didn't affect regular publishers/subscribers, as micro-ROS
rmw_microxrcedds
destroy methods handles the internal datawriter/reader destruction: detail.