fix udp_transport: call freeaddrinfo only if getaddrinfo succeeded (#359

) Otherwise freeaddrinfo can access invalid memory. Signed-off-by: Beat Küng <beat-kueng@gmx.net>
eProsima · Jun 15, 2023 · 70924f2 · 70924f2
1 parent 5cd43eb
commit 70924f2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/c/profile/transport/ip/udp/udp_transport_posix.c b/src/c/profile/transport/ip/udp/udp_transport_posix.c
@@ -54,8 +54,8 @@ bool uxr_init_udp_platform(
                     break;
                 }
             }
+            freeaddrinfo(result);
         }
-        freeaddrinfo(result);
     }
     return rv;
 }

diff --git a/src/c/profile/transport/ip/udp/udp_transport_posix_nopoll.c b/src/c/profile/transport/ip/udp/udp_transport_posix_nopoll.c
@@ -55,8 +55,8 @@ bool uxr_init_udp_platform(
                     break;
                 }
             }
+            freeaddrinfo(result);
         }
-        freeaddrinfo(result);
     }
     return rv;
 }

diff --git a/src/c/profile/transport/ip/udp/udp_transport_windows.c b/src/c/profile/transport/ip/udp/udp_transport_windows.c
@@ -56,8 +56,8 @@ bool uxr_init_udp_platform(
                     break;
                 }
             }
+            freeaddrinfo(result);
         }
-        freeaddrinfo(result);
     }
     return rv;
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -54,8 +54,8 @@ bool uxr_init_udp_platform( @@
                         break;
                     }
                 }
+                freeaddrinfo(result);
             }
-            freeaddrinfo(result);
         }
         return rv;
     }
@@ Expand Down @@